Antalya 26.3: OAuth -- rework Entra ID workflow#1784
Merged
Conversation
zvonand
added
port-antalya
Resolved 3 OAuth-side conflicts: - TokenProcessorsParse.cpp: kept the audit branch's per-endpoint require_allowed_url validation in the openid `locally_configured` path; adapted the entra preset to the same conventions -- require_allowed_url on configuration_endpoint, allow_http_discovery_urls support, LOG_WARNING when expected_issuer / expected_audience are empty, remote_host_filter passed through to OpenIdTokenProcessor. - TokenAccessStorage.cpp: collapsed the auth loop into a single roles_mapping -> roles_filter -> roles_transform pipeline behind the audit branch's defensive `roles_filter->ok()` guard so a broken regex cannot fall through to the permissive grant-all branch. - TokenProcessorsOpaque.cpp: took the audit branch's discovery hardening wholesale (URL allow-list, HTTPS-on-discovery-returned-URLs, issuer-anchor verification, jwks_uri required when expected_issuer/audience are set). Rebuilt clean. Verified: test_token_roles_mapping 4/4, test_jwt_auth 6/6, test_keycloak_auth 8/8. PR: #1777 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zvonand
changed the title
zvonand
changed the title
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1777
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added a new
entraprocessor type which works with Entra through OIDC flow -- token is validated locally using Entra JWKS. Oldazuretype will be an alias.User now needs to specify
tenant_idin configuration.CI/CD Options
Exclude tests:
Regression jobs to run: