feat: add dev-workflow skill for harness sandbox#711
feat: add dev-workflow skill for harness sandbox#711saravmajestic wants to merge 3 commits intomainfrom
Conversation
- Fix health_path: /global/health (was empty) - Document two-phase sandbox lifecycle (code-ready / server-ready) - Add verification section: tests, health check, curl, CLI commands - Update start_command to use bun --hot for live module reloading Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughA new skill documentation file was added at Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/skills/dev-workflow/SKILL.md:
- Line 61: The Docker base image reference "base_image:
altimateacr.azurecr.io/altimate-code-base:latest" should be pinned to an
immutable tag or digest to ensure reproducible builds; update the value of the
base_image entry (the "base_image" key) to use a specific versioned tag (e.g.,
v1.2.3) or an exact image digest (sha256:...) instead of ":latest" so the
sandbox contract uses a fixed, immutable image.
- Around line 96-98: The health-check example currently asserts a fixed version
in the expected response; update the /global/health curl example (the curl -sf
localhost:4096/global/health block and the commented Expected JSON) to avoid
asserting "version":"local" — either show only {"healthy": true} or state that
"version" is runtime-derived and may vary, so tests should only assert
healthy:true; keep the curl command and clarify the dynamic nature of the
version field in the surrounding text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b0504f5f-90e0-47d2-83f5-66b95ae7faf9
📒 Files selected for processing (1)
.claude/skills/dev-workflow/SKILL.md
| ```yaml | ||
| repo: altimate-code | ||
| repo_url: https://github.com/AltimateAI/altimate-code.git | ||
| base_image: altimateacr.azurecr.io/altimate-code-base:latest |
There was a problem hiding this comment.
Pin the base image to an immutable version/digest.
Using :latest in the sandbox contract makes environment behavior non-deterministic across runs and can break reproducibility.
Suggested doc fix
-base_image: altimateacr.azurecr.io/altimate-code-base:latest
+# Prefer immutable pinning for reproducibility:
+# base_image: altimateacr.azurecr.io/altimate-code-base:<version-or-date-tag>
+# or (stronger):
+# base_image: altimateacr.azurecr.io/altimate-code-base@sha256:<digest>
+base_image: altimateacr.azurecr.io/altimate-code-base:<pinned-tag>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/dev-workflow/SKILL.md at line 61, The Docker base image
reference "base_image: altimateacr.azurecr.io/altimate-code-base:latest" should
be pinned to an immutable tag or digest to ensure reproducible builds; update
the value of the base_image entry (the "base_image" key) to use a specific
versioned tag (e.g., v1.2.3) or an exact image digest (sha256:...) instead of
":latest" so the sandbox contract uses a fixed, immutable image.
| curl -sf localhost:4096/global/health | ||
| # Expected: {"healthy":true,"version":"local"} | ||
| ``` |
There was a problem hiding this comment.
Avoid asserting a fixed version value in health-check expectations.
The endpoint guarantees healthy: true, but version is runtime-derived. Documenting {"version":"local"} can cause false verification failures.
Suggested doc fix
curl -sf localhost:4096/global/health
-# Expected: {"healthy":true,"version":"local"}
+# Expected: JSON containing `"healthy": true` (version value may vary by build/runtime)
+# Example check:
+# curl -sf localhost:4096/global/health | jq -e '.healthy == true'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| curl -sf localhost:4096/global/health | |
| # Expected: {"healthy":true,"version":"local"} | |
| ``` | |
| curl -sf localhost:4096/global/health | |
| # Expected: JSON containing `"healthy": true` (version value may vary by build/runtime) | |
| # Example check: | |
| # curl -sf localhost:4096/global/health | jq -e '.healthy == true' |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/dev-workflow/SKILL.md around lines 96 - 98, The health-check
example currently asserts a fixed version in the expected response; update the
/global/health curl example (the curl -sf localhost:4096/global/health block and
the commented Expected JSON) to avoid asserting "version":"local" — either show
only {"healthy": true} or state that "version" is runtime-derived and may vary,
so tests should only assert healthy:true; keep the curl command and clarify the
dynamic nature of the version field in the surrounding text.
|
Closing — dev-workflow skill moved to the harness repo (private) and injected at spawn time. Public repos should not contain internal harness infrastructure. |
1 participant
Summary
Tested
altimate-code-base:latestSummary by cubic
Adds a
dev-workflowskill to runaltimate-codein a Harness sandbox with a stable contract,/global/healthendpoint, hot-reload start, and a two-phase readiness (code-ready → server-ready) for faster iteration..claude/skills/dev-workflow/SKILL.mdfor sandbox onboarding.altimateacr.azurecr.io/altimate-code-base:latest, working dir/workspace/altimate-code, port4096,health_path: /global/health./workspace/.code-readyand/workspace/.server-ready.bun --hotstart; server binds0.0.0.0:4096.Written for commit b0c8182. Summary will update on new commits.
Summary by CodeRabbit