Repository navigation
fix(telemetry): stop reporting user permission rejections as tool errors - #1697
altimate-software-factory[bot] wants to merge 1 commit into
Conversation
Factory lane: altimate_code. Agent-Authored-By: altimate-factory
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Summary
Automated fix proposed by the Altimate software factory; a maintainer reviews every change.
The problem, fix and criteria below are the agent's own account; check them against the diff.
Problem
The session telemetry loop turned every failed tool call into an error fingerprint, including calls that failed only because the user chose to reject the permission prompt, which is an expected decision rather than a tool failure.
Fix
Tool calls that fail only because the user rejected the permission prompt are no longer recorded as error_fingerprint tool errors, while config denials and other permission failures still are.
Acceptance criteria
Changes
3 files changed, 41 lines added, 0 lines removed.
packages/opencode/src/altimate/telemetry/error-detail.tspackages/opencode/src/session/prompt.tspackages/opencode/test/telemetry/user-rejection.test.tsNew tests
packages/opencode/test/telemetry/user-rejection.test.tsIndependent review: accepted, confidence 0.88
Verification
Summary by cubic
Fixes the session telemetry loop so user rejections of permission prompts are no longer recorded as error fingerprints.
Tool calls that fail only because the user rejected or corrected the permission prompt are now skipped, while config-rule denials and other permission failures still produce error fingerprints. Adds
isUserRejectionto distinguish those cases and tests covering the real rejection and denial messages.Written for commit 1636c79. Summary will update on new commits.