Repository navigation
fix(codex): allowlist gpt-6.1-terra for ChatGPT-subscription users - #1673
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
1 similar comment
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
🤖 Code Review — OpenCodeReview (Gemini) — No Issues FoundNo supported files changed. |
Issue for this PR
Closes #1623
Type of change
What does this PR do?
OAUTH_ALLOWED_MODELSinpackages/opencode/src/plugin/codex.tshidesgpt-6.1-terrafrom ChatGPT Plus/Pro users, even though the official Codex client lists it for them.Added (catalogs fetched 2026-11-05):
openai/codexcodex-rs/models-manager/models.jsononmain)openaigpt-6.1-terravisibility: "list", priority 7,upgrade: null,minimal_client_version0.153.0,plus/proinavailable_in_plansRemoved: none. No allowlisted id has a retirement date or
visibility: "hide":gpt-5.3-codex-sparkis missing from the catalog, but it is missing from every revision I checked (back to openai/codex@cf6754e6, 2026-09-21), and #1565 records the same back to 2026-04. It stays because it was backend-probed (VERIFIED_ACCEPTED). The replacement targetsgpt-6-solandgpt-6-lunaaren't allowlisted onmainyet. #1565 adds them.Relationship to #1565. #1565 (open, closes #1564) adds
gpt-6-astra,gpt-6-luna,gpt-6-solandgpt-6.1-sol. It was written before openai/codex addedgpt-6.1-terra, so it doesn't include it. Both PRs use the same structure: aCATALOG_VERIFIED_UNPROBEDtest constant and analtimate_changeblock at the end of the set. Whichever merges second will hit a small textual conflict. The fix is to merge the twoCATALOG_VERIFIED_UNPROBEDarrays and the two marker blocks.How the change is structured. Same convention as #1565:
gpt-6.1-terragoes into a new test constant,CATALOG_VERIFIED_UNPROBED, notVERIFIED_ACCEPTED. The probed truth table stays honest.OAUTH_ALLOWED_MODELS == VERIFIED_ACCEPTED ∪ CATALOG_VERIFIED_UNPROBED.codex.ts, the id sits inside analtimate_changeblock (codex.tsis inrequireMarkers). The block records the catalog evidence.Not touched:
plugin/openai/codex.tsALLOWED_MODELS. That file still isn't wired, and its comments don't ask for parity. ItsparseFloat > 5.4fallback would already admitgpt-6.1-terra.auth.type === "oauth".Cold-cache caveat. The committed
provider/models-snapshot.tshas no GPT-6 entry, so a source checkout won't show this model until the catalog refreshes. Release builds embed the live models.dev catalog (#1188), and that catalog has it.How did you verify your code works?
bun test test/plugin/codex-allowlist.test.ts test/plugin/codex.test.tsinpackages/opencode: 34 pass, 0 fail.bun typecheck: the default parallel run is OOM-killed on this 7 GB sandbox, which has nothing to do with this diff.bun turbo typecheck --concurrency=1passes for the other 12 packages, andtsgo --noEmit --singleThreadedinpackages/opencodeis clean.bun run script/upstream/analyze.ts --markers --base origin/main --strict: ok.bun script/check-tracker-leaks.ts: clean.gpt-6.1-terra(see the top of this description).Cost side effects
None. This only changes which ids the OAuth model picker keeps. It adds no model calls, queries or resources.
Screenshots / recordings
N/A, not a UI change.
Checklist
Written by Devin
Summary by cubic
Adds
gpt-6.1-terratoOAUTH_ALLOWED_MODELSinpackages/opencode/src/plugin/codex.tsso ChatGPT Plus/Pro users can pick it, matching the official Codex client catalog. Closes #1623.The model is catalog-verified but hasn't been backend-probed, so it's kept in a new
CATALOG_VERIFIED_UNPROBEDtest bucket and the allowlist trip-wire now assertsOAUTH_ALLOWED_MODELS == VERIFIED_ACCEPTED ∪ CATALOG_VERIFIED_UNPROBED.Notes
gpt-6.1-terraagainst the live Codex endpoint before merging; move it toVERIFIED_ACCEPTEDon HTTP 200, or drop it from the allowlist on HTTP 400.Written for commit 012ab9a. Summary will update on new commits.