fix: hook printf + plugin.json homepage#4
Merged
Conversation
Three cleanup items surfaced during review of the sibling altimate-codex-plugin (PR #2) that also apply here but weren't included in this repo's PR #2: - **Hook script: `cat <<'EOF'` → `printf` lines.** The here-doc form can fail in restricted sandboxes that refuse to create the temporary file a here-doc needs (`cannot create temp file for here document: Operation not permitted`). `printf` has no such dependency. Output is byte-identical when parsed as JSON. - **Hook script: drop the redundant trailing `exit 0`.** Bash exits with the status of the last command by default; the explicit `exit` adds no signal. - **plugin.json: `homepage` → repo URL.** The previous value (`https://altimate.ai`) was redundant with `author.url` and hid the direct source link a marketplace browser would expect. Verified: `bash -n` clean; running the hook produces valid JSON whose `hookSpecificOutput.hookEventName == "SessionStart"` and preserves the "Claude" reference in `additionalContext` (this IS the Claude plugin, so the reference is factually correct here — unlike the sibling codex and opencode plugins where the same reference was factually wrong and had to be scrubbed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2. Three cleanup items surfaced during review of the sibling altimate-codex-plugin PR #2 that also apply here but weren't included in this repo's earlier PR.
What changed
plugins/altimate-code/hooks-handlers/session-start.sh: replacedcat <<'EOF'here-doc withprintflines. The here-doc form can fail in restricted sandboxes that refuse to create the temporary file a here-doc needs (cannot create temp file for here document: Operation not permitted).printfhas no such dependency. Output is byte-identical when parsed as JSON.exit 0— bash exits with the status of the last command by default.plugins/altimate-code/.claude-plugin/plugin.json:homepagemoved fromhttps://altimate.aito the repo URL. The previous value was redundant withauthor.urland hid the direct source link a marketplace browser would expect.Verification
bash -nclean on the hook.hookSpecificOutput.hookEventName == "SessionStart".additionalContextis preserved intentionally — this IS the Claude plugin, so the reference is factually correct here. On the sibling codex and opencode plugins the same reference was factually wrong (agent-facing content in a non-Claude host) and had to be scrubbed.What's explicitly NOT changed