Battle/feature - Win Lose Server Call #1226
Open
+108
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Should mean now that the photon id and the accountId should match.
roope-hiironniemi
changed the title
Changed logging to use BattleDebugLogger Improved code readability
Niklas603619
approved these changes
Jan 19, 2026
Contributor
Niklas603619
left a comment
Niklas603619
left a comment
There was a problem hiding this comment.
Battle changes approved
There is some problems with the server call
@BillTheBeast can check the problems and should review ServerManager changes
Changed durationSec from float to int Changed to only send playerUserIds that are in the game
Improved formatting Added some comments Removed unnecessary white space
Disabled Debug.LogWarning since it unnecessarily clutters logs when not debugging this specific method
BillTheBeast
approved these changes
Jan 20, 2026
Contributor
BillTheBeast
left a comment
BillTheBeast
left a comment
There was a problem hiding this comment.
Toi for looppi, jossa team1 ja team2 arrayt asetetaan, on varmaankin mahdollista tehdä hieman yksinkertaisemmin kuin mitä tuo nyt on tuossa.
Mutta muuten ihan jees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added server call for battle results. Now server is able to track wins and losses.
LobbyManager
ServerManager
InLobbyController
SoulHomeLoad
BattleGameViewController