[OGUI-1917] Add copy URL button to toolbar - #3616
Draft
isaachilly wants to merge 23 commits into
Draft
Conversation
isaachilly
changed the title
isaachilly
changed the title
isaachilly
force-pushed
the
feature/ILG/OGUI-1917/Add-shareable-url-button
branch
3 times, most recently
from
September 8, 2026 12:18
65ce0a5 to
2ddc5aa
Compare
isaachilly
force-pushed
the
feature/ILG/OGUI-1917/Add-shareable-url-button
branch
5 times, most recently
from
September 8, 2026 15:01
eb4c274 to
1b8c01e
Compare
isaachilly
changed the title
isaachilly
force-pushed
the
feature/ILG/OGUI-1917/Add-shareable-url-button
branch
from
September 9, 2026 06:59
c638dc9 to
dd04f15
Compare
isaachilly
force-pushed
the
feature/ILG/OGUI-1917/Add-shareable-url-button
branch
from
September 11, 2026 13:31
dd04f15 to
16c659d
Compare
Register the InfoLogger model with `StatefulComponent` so shared stateful UI components can render correctly. Add a `CopyToClipboardComponent` button in the command logs toolbar that copies the current filter query string as a URL.
Switch the command logs copy action to use `location.href`.
Add a new test suite for the copy URL button. The new tests verify the button label and confirm that clicking it copies a URL containing the encoded active filter query.
Switch the log view Copy URL button to consume a new `LogFilter.filterURL` getter instead of rebuilding from a query string in the button component.
Move the shareable URL logic to the main model from the more specific log filter model. Build URL using `queryRouter.getUrl` and replacing the search.
Wires an `onFailure` handler so clipboard errors are surfaced to users as a danger notification. Adds a test that simulates a clipboard rejection and verifies the expected notification state, type, and message.
Adjust the copy URL button mocha test to use the current log filtering API and assert copy failures through the rendered danger notification instead of reading notification state directly.
Pass the notification `show` method as a bound callback when rendering the copy URL button.
isaachilly
force-pushed
the
feature/ILG/OGUI-1917/Add-shareable-url-button
branch
from
September 14, 2026 12:49
1b34e65 to
63770cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Give the user an easy, developer-controlled way to copy a safe, shareable URL. This avoids confusion about how the URL should be encoded, and protects against browser address bar behaviour differences catching users out.
Code:
CopyToClipboardComponentupdated in OGUI-1919.Reviewer:
writeTextto raise an Error and click the button.