Skip to content

[OGUI-1874] Notify user on Buffer being full#3479

Merged
isaachilly merged 8 commits into
devfrom
feature/ILG/OGUI-1874/Notify-user-on-buffer-being-full
May 26, 2026
Merged

[OGUI-1874] Notify user on Buffer being full#3479
isaachilly merged 8 commits into
devfrom
feature/ILG/OGUI-1874/Notify-user-on-buffer-being-full

Conversation

@isaachilly
Copy link
Copy Markdown
Collaborator

@isaachilly isaachilly commented May 26, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful
image image
  • Adds a dot indicator to track whether the query hit the buffer limit or not.
  • Changes format of messages count in the status bar from "100000 messages" to "100,000 / 100,000 (Buffer size)".
  • Displays a warning notification when the buffer size is hit.
  • Adds tests for the status bar
  • Enhances notifications by adding click-top-copy functionality.
  • Enhances notifications by making them not hide if hovered over.

Adds a dot indicator to track whether the query hit the buffer limit or not.

Changes format of messages count in the status bar from "100000 messages" to "100,000 / 100,000 (Buffer size)".

Displays a warning notification when buffer size hit.
…ments

Clicking a notification copies its text to clipboard.

Hovering a notification stops the auto-hiding of it.
Add test suite for the status bar, not only the new buffer size indicator but its other components.

Tests added cover: service status states, buffer size indicator, severity counters, SQL query, application limit and the autoscroll and inspector checkboxes.

NOTE: Test suite at this moment does not cover the buffer size limit notification.
@isaachilly isaachilly self-assigned this May 26, 2026
@isaachilly isaachilly added Frontend InfoLogger javascript Pull requests that update javascript code labels May 26, 2026
@isaachilly isaachilly marked this pull request as ready for review May 26, 2026 12:28
@isaachilly isaachilly requested a review from graduta as a code owner May 26, 2026 12:28
Copy link
Copy Markdown
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep in mind that framework is a different NPM package. Thus, it needs to have its own ticket and PRs, followed up by a release. Only after, it can be used in the other projects.
Given that, the improvements for Notification are not to be applied in this PR at all

Comment thread InfoLogger/public/log/statusBar.js Outdated
Comment thread InfoLogger/public/log/statusBar.js Outdated
Comment thread InfoLogger/test/public/status-bar-mocha.js Outdated
@isaachilly
Copy link
Copy Markdown
Collaborator Author

Please keep in mind that framework is a different NPM package. Thus, it needs to have its own ticket and PRs, followed up by a release. Only after, it can be used in the other projects. Given that, the improvements for Notification are not to be applied in this PR at all

Ah yes, my fault, will remove and stash.

…ibutes

Replace inline hex colours and styles with existing framework classes for consistency and ease of testing.

Update affected tests.
@isaachilly isaachilly requested a review from graduta May 26, 2026 15:18
@isaachilly isaachilly merged commit 2765af7 into dev May 26, 2026
10 checks passed
@isaachilly isaachilly deleted the feature/ILG/OGUI-1874/Notify-user-on-buffer-being-full branch May 26, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend InfoLogger javascript Pull requests that update javascript code

Development

Successfully merging this pull request may close these issues.

2 participants