Repository navigation
[PWGLF] task to measure charged particles spectra in ultracentral collisions - #18806
Draft
rosher-diana wants to merge 1 commit into
Draft
rosher-diana wants to merge 1 commit into
rosher-diana wants to merge 1 commit into
Conversation
rosher-diana
requested review from
abmodak,
alibuild,
gbencedi,
mpuccio,
omvazque and
skundu692
as code owners
November 18, 2026 17:11
|
O2 linter results: ❌ 0 errors, |
vkucera
marked this pull request as draft
November 19, 2026 13:30
vkucera
reviewed
Nov 19, 2026
Comment on lines
+52
to
+53
| o2physics_add_dpl_workflow(heatcap-task | ||
| SOURCES heatcapacity.cxx |
Collaborator
There was a problem hiding this comment.
Please follow the naming conventions.
Comment on lines
+12
to
+13
| /// \brief | ||
| /// \author everyone |
Collaborator
There was a problem hiding this comment.
Please write a proper documentation.
| /// \author everyone | ||
|
|
||
| #include <Framework/AnalysisDataModel.h> // tpcNClsCrossedRows | ||
| #include <Framework/AnalysisTask.h> // |
Collaborator
There was a problem hiding this comment.
Please configure your editor to trim trailing whitespaces.
| using CollisionCandidates = soa::Join<aod::Collisions, aod::EvSels, aod::CentFT0Cs, aod::PVMults, aod::MultsGlobal, aod::Mults>; | ||
| using TrackCandidates = soa::Join<aod::Tracks, aod::TracksDCA, aod::TracksExtra>; | ||
|
|
||
| struct CentralityClassificationPbPb |
Collaborator
There was a problem hiding this comment.
Why is the task implemented in a file with a completely different name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.