Skip to content

[PWGDQ] improvements to the event selection in matching QA task - #18803

Merged
lucamicheletti93 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-matching-qa-allow-selection-of-mother-resonance
Nov 19, 2026
Merged

lucamicheletti93 merged 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-matching-qa-allow-selection-of-mother-resonance

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor
  • allow selective analysis of muons from charmonia and bottomia decays
  • fix extrapolation to matching planes downstream of the absorber
  • allow processing of a configurable fraction of the events

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 12 warnings, 🔕 7 disabled

@aferrero2707
aferrero2707 force-pushed the PWGDQ-matching-qa-allow-selection-of-mother-resonance branch 2 times, most recently from eebaa2a to 221157d Compare November 18, 2026 13:52
@aferrero2707
aferrero2707 marked this pull request as ready for review November 18, 2026 13:57
- allow selective analysis of muons from charmonia and bottomia decays
- fix extrapolation to matching planes downstream of the absorber
- allow processing of a configurable fraction of the events
@aferrero2707
aferrero2707 force-pushed the PWGDQ-matching-qa-allow-selection-of-mother-resonance branch from 221157d to 92c2c00 Compare November 18, 2026 14:44
@alibuild

alibuild commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 92c2c00 at 2026-11-19 03:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 67 warnings.'
Found 8 errors and 67 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/dfc2aa36a26b668cfc288b55e180027e5b6f8cdf/O2Physics-code-check/errors.txt
PWGDQ/Tasks/qaMatching.cxx:505:18: error: no header providing "o2::vertexing::FwdDCAFitterN" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:620:58: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:726:67: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:808:67: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:1129:65: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:1139:62: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:1144:62: error: the parameter 'hn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGDQ/Tasks/qaMatching.cxx:2176:17: error: no header providing "ROOT::Math::XYZVector" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 67 -gt 0 ]]
++ cat /sw/BUILD/dfc2aa36a26b668cfc288b55e180027e5b6f8cdf/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/qaMatching.cxx:1344:11: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1344:26: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1344:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1372:11: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1372:26: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1372:70: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGDQ/Tasks/qaMatching.cxx:1372:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1440:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGDQ/Tasks/qaMatching.cxx:1456:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1507:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1511:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1526:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1530:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1543:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1557:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1566:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1836:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1891:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1934:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1968:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1970:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1976:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1979:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:1990:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:2006:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/Tasks/qaMatching.cxx:2047:38: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@aferrero2707

aferrero2707 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@lucamicheletti93 @mguilbau could you please have a look and merge if ok? There are quite some changes, all in the matching QA task, that are needed to better understand the matching performances for charmonia decays.

I will address the code checker errors in a next PR, since they are harmless and I would prefer to avoid running the CI once more.

Thanks!

@lucamicheletti93
lucamicheletti93 merged commit 090a88d into AliceO2Group:master Nov 19, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants