Skip to content

[PWGLF] Add Energy info of zdc with correlation with azimuth - #18780

Merged
skundu692 merged 2 commits into
AliceO2Group:masterfrom
skundu692:zdcenergyinfo
Nov 16, 2026
Merged

skundu692 merged 2 commits into
AliceO2Group:masterfrom
skundu692:zdcenergyinfo

Conversation

@skundu692

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 115 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add Energy info of zdc with correlation with azimuth [PWGLF] Add Energy info of zdc with correlation with azimuth Nov 16, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ed3338a at 2026-11-16 21:57:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 14 warnings.'
Found 1 errors and 14 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/37375e889876b7bbafd971bfc5574afe10238773/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:236:29: error: the parameter 'profile' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/37375e889876b7bbafd971bfc5574afe10238773/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:164:35: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:238:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:242:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:565:77: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:623:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:649:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:729:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:733:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:734:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:736:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:894:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:905:15: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:906:15: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:1480:38: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Fix unnecessary histogram pointer copy
@skundu692
skundu692 enabled auto-merge (squash) November 16, 2026 21:18

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @skundu692.

@skundu692
skundu692 merged commit 3d5e347 into AliceO2Group:master Nov 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants