Skip to content

[PWGCF] FemtoUniverse V0 and Cascade Task -- added matrix table for per daughter cpr cuts - #18774

Merged
prchakra merged 2 commits into
AliceO2Group:masterfrom
Eloviyo:matrixTableForCPRCuts
Nov 16, 2026
Merged

prchakra merged 2 commits into
AliceO2Group:masterfrom
Eloviyo:matrixTableForCPRCuts

Conversation

@Eloviyo

@Eloviyo Eloviyo commented Nov 16, 2026

Copy link
Copy Markdown
Contributor
  • added matrix table to apply cpr cuts per daughter for both V0s and cascades : the default is set 0.0 which falls back to scalar cpr (i.e. it doesn't affect other analysis)

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3ea497c at 2026-11-16 18:53:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 25 errors and 113 warnings.'
Found 25 errors and 113 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/e59168f162844736e6dba70e4af1bb3739497eb4/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:330:64: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:167:94: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:169:100: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:171:93: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:172:98: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:175:94: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:178:93: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:181:89: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:184:99: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:187:88: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:188:93: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx:1463:30: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:123:89: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:124:91: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:125:95: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:128:88: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:129:90: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:130:94: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:171:61: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:172:91: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:173:95: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:176:88: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:177:90: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:178:94: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Extended.cxx:1504:30: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
++ [[ 113 -gt 0 ]]
++ cat /sw/BUILD/e59168f162844736e6dba70e4af1bb3739497eb4/O2Physics-code-check/warnings.txt
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:49:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:64:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:87:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:90:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:116:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:136:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:151:7: warning: constructor does not initialize these fields: chosenRadii, cutDeltaPhiStarMax, cutDeltaPhiStarMin, cutDeltaEtaMax, cutDeltaEtaMin, magfield, cutPhiInvMassLow, cutPhiInvMassHigh [cppcoreguidelines-pro-type-member-init]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:370:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/FemtoUniverse/Core/FemtoUniverseDetaDphiStar.h:467:117: warning: repeated branch body in conditional chain [bugprone-branch-clone]
[0 more errors; see full log]

Full log here.

@github-actions github-actions Bot added the pwgcf label Nov 16, 2026
@github-actions github-actions Bot changed the title PWGCF: FemtoUniverse V0 and Cascade Task -- added matrix table for per daughter cpr cuts [PWGCF] FemtoUniverse V0 and Cascade Task -- added matrix table for per daughter cpr cuts Nov 16, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 94 warnings, 🔕 0 disabled

@prchakra
prchakra merged commit 1d58b83 into AliceO2Group:master Nov 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants