[PWGJE] Bugfixes in JE tasks - #17903
Merged
Merged
Conversation
mhwang285
commented
Sep 14, 2026
mhwang285
commented
Contributor
- Kappa and alpha were not being used in some angularity calculations
- Resolved some O2 linter issues (most but not all)
- Fixed two mislabeled histogram axes in jetSpectraCharged.cxx
mhwang285
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
September 14, 2026 06:54
|
O2 linter results: ❌ 9 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for 0fdf62c at 2026-09-14 10:39: Full log here. |
nzardosh
reviewed
Sep 14, 2026
nzardosh
left a comment
nzardosh
left a comment
Collaborator
There was a problem hiding this comment.
Dear Tucker, thanks for making the changes. I have left a couple of comments.
For a future note it is best not to change the analysis tasks written by other analysers, even if the changes are cosmetic (unless discussed with them first, in which case please disregard this) as they might be making changes of their own in their local branches. @aimeric-landou @joonsukbae could you please check and make sure you are ok with the changes proposed.
| Filter eventCuts = (nabs(aod::jcollision::posZ) < vertexZCut && | ||
| ((checkCentFT0M ? aod::jcollision::centFT0M : aod::jcollision::centFT0C) >= centralityMin) && | ||
| ((checkCentFT0M ? aod::jcollision::centFT0M : aod::jcollision::centFT0C) < centralityMax)); | ||
| PresliceUnsorted<soa::Filtered<aod::JetCollisionsMCD>> CollisionsPerMCPCollision = aod::jmccollisionlb::mcCollisionId; |
Collaborator
There was a problem hiding this comment.
For these could you put them back please? even though it goes against the convention in most of the framework I use capitals for preslices to differentiate them. We might decide to change this globally for later but for now would be nice to keep it consistent
| angularityMcd += std::pow(constituent.pt(), kappa) * std::pow(jetutilities::deltaR(jetMCD, constituent), alpha); | ||
| angularityMcd += std::pow(constituent.pt(), kappa) * std::pow(jetutilities::deltaR(jetMCD, constituent) / (jetMCD.r() / 100.f), alpha); | ||
| } | ||
| angularityMcd /= (corrBasejetpt * (jetMCD.r() / 100.f)); |
Collaborator
There was a problem hiding this comment.
in line 746 there is a division by the radius. There shouldnt be another one here i think?
Contributor
Author
There was a problem hiding this comment.
Ah thanks for catching that, I fixed 746 but not 748, both lines are fixed now. I also had to change corrTagjetpt, corrBasejetpt, and dcorrpt to floats so that we can use std::pow with a kappa (which is float)
Collaborator
|
Error while checking build/O2Physics/code-check for 7658b87 at 2026-09-15 00:52: Full log here. |
Contributor
Dear @mhwang285 and @nzardosh, it looks good to me. The type/name changes and the angularity expansion also look good. Thank you also for catching the switched MCD vs. MCP axis labels. |
nzardosh
self-requested a review
September 16, 2026 10:58
nzardosh
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.