[PWGCF] Add efficiency-corrected multiplicity information to CF derived data by EmilGorm · Pull Request #17783 · AliceO2Group/O2Physics

EmilGorm · 2026-09-05T18:22:39Z

CorrelationsDerived.h: Efficiency-corrected multiplicity now stored in dedicated CFCollisionsExtra table as sum of per track weight
Keep track of track-based multiplicity in transient CFMultiplicities for efficiency correction purposes
filterCorrelations.cxx: fill efficiency-corrected multiplicity when an efficiency file is supplied to the table producer
- Only filled when the track-based multiplicity is used
twoParticleCorrelationsMpi.cxx: utilise the efficiency-corrected multiplicity
- dedicated process functions
- compile-time lookup to switch on multiplicity
- Added option for MC efficiency calculations to only use one reconstructed event per generated collision

…ra table

…calculation

github-actions · 2026-09-05T18:22:55Z

O2 linter results: ❌ 0 errors, ⚠️ 5 warnings, 🔕 27 disabled

alibuild · 2026-09-05T23:39:39Z

Error while checking build/O2Physics/code-check for ab8043d at 2026-09-06 01:39:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 37 warnings.'
Found 8 errors and 37 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/2717567cf1fcf8868fe5b922e883b019aa09d5fa/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:65:9: error: macro 'FLOAT_PRECISION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:66:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:68:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:182:43: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:544:54: error: narrowing conversion from 'double' to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:672:19: error: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:672:21: error: narrowing conversion from 'Double_t' (aka 'double') to 'int8_t' (aka 'signed char') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:1344:28: error: parameter 'target' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 37 -gt 0 ]]
++ cat /sw/BUILD/2717567cf1fcf8868fe5b922e883b019aa09d5fa/O2Physics-code-check/warnings.txt
PWGCF/TableProducer/filterCorrelations.cxx:58:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGCF/TableProducer/filterCorrelations.cxx:151:36: warning: initializer for member 'multiplicities' is redundant [readability-redundant-member-init]
PWGCF/TableProducer/filterCorrelations.cxx:207:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:212:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:224:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:226:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:226:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:281:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:285:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:414:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:416:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:418:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:420:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:422:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:427:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:436:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:483:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:485:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:564:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:596:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:598:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:600:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:602:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:604:60: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:609:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:622:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:668:113: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:671:76: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:672:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:300:45: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:300:68: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:300:100: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

alibuild · 2026-09-06T01:50:46Z

Error while checking build/O2Physics/o2 for ab8043d at 2026-09-06 03:50:

## sw/BUILD/O2Physics-latest/log
2026-09-06T03:43:47.028+0200 [15684:139682273181312] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.029+0200 [15684:139682273181312] [executioncontext.cpp:739] [ERROR] Failed to download output blob 68658dc99c9aa03e2d5c28e07e4b94a04743338afbc00fbc220b791be4708780: 14: Socket closed
2026-09-06T03:43:47.026+0200 [15570:139884316712576] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.037+0200 [15570:139884316712576] [executioncontext.cpp:739] [ERROR] Failed to download output blob f9bba967a6e9f6fb84626795894cd8b99169a4fbe1d4b82e7792a9db870d2654: 14: Socket closed
2026-09-06T03:43:47.027+0200 [14970:140470453821056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.053+0200 [14970:140470453821056] [executioncontext.cpp:739] [ERROR] Failed to download output blob b26515bcae0f729712ca6a8b4b1fc3c958abc4108caaf10b20290ee2d2c0acd9: 14: Socket closed
2026-09-06T03:43:47.027+0200 [14799:139750577237632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.054+0200 [14799:139750577237632] [executioncontext.cpp:739] [ERROR] Failed to download output blob 3cd5232b706b660065f3c131c2589293938adb8398df72cc7faaa0ea06ddcb5a: 14: Socket closed
2026-09-06T03:43:47.537+0200 [2955:140689837919872] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-06T03:43:47.026+0200 [15644:139995682107008] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.028+0200 [15644:139995682107008] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-06T03:43:47.026+0200 [15615:139766955552384] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.028+0200 [15615:139766955552384] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-06T03:43:47.026+0200 [15612:140174315798144] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.028+0200 [15612:140174315798144] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-06T03:43:47.028+0200 [16006:140435223244416] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [16006:140435223244416] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15962:139821481696896] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15962:139821481696896] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.027+0200 [15728:140582415212160] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.028+0200 [15728:140582415212160] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-06T03:43:47.028+0200 [15918:140139569868416] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15918:140139569868416] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.027+0200 [15785:140570010427008] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15785:140570010427008] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15786:140464174440064] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15786:140464174440064] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [16056:140022056738432] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [16056:140022056738432] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15750:140571584626304] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15750:140571584626304] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15917:139783239753344] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15917:139783239753344] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.027+0200 [15706:140135482142336] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
2026-09-06T03:43:47.028+0200 [15706:140135482142336] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: Socket closed
2026-09-06T03:43:47.028+0200 [16003:140017676234368] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [16003:140017676234368] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15857:139891079503488] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15857:139891079503488] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15851:140709797777024] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15851:140709797777024] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15829:139709808721536] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15829:139709808721536] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
2026-09-06T03:43:47.028+0200 [15807:139642454171264] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer]
2026-09-06T03:43:47.028+0200 [15807:139642454171264] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNAVAILABLE: ipv4:127.0.0.1:8980: recvmsg:Connection reset by peer
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-07T11:10:42Z

Error while checking build/O2Physics/code-check for 2e1d276 at 2026-09-07 13:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 4 warnings.'
Found 2 errors and 4 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/9c7bd409c8c17add3db05522515b6988c35bf448/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:65:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TableProducer/filterCorrelations.cxx:131:106: error: no header providing "M_PI" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/9c7bd409c8c17add3db05522515b6988c35bf448/O2Physics-code-check/warnings.txt
PWGCF/TableProducer/filterCorrelations.cxx:230:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TableProducer/filterCorrelations.cxx:287:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:291:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGCF/TableProducer/filterCorrelations.cxx:644:32: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Please consider the following formatting changes to AliceO2Group#17783

alibuild · 2026-09-10T06:23:37Z

Error while checking build/O2Physics/code-check for 2b63f3b at 2026-09-10 12:55:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/a7fe89e3eaf01f2edfe11251421236efc5c228ec/O2Physics-code-check/errors.txt
PWGCF/TableProducer/filterCorrelations.cxx:365:5: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Please consider the following formatting changes to AliceO2Group#17783

jgrosseo

See my two comments.

What I find not good is that we have now a processMCEfficiency in correlations.cxx and in this task. I think we should only duplicate things which are strictly MPI related, while the efficiency improvements could also be useful for other analysis and I don't see any issue for others with your changes. What do you think?

jgrosseo · 2026-09-11T09:49:57Z

+    if (!collision.isTrackMultiplicity()) {
+      LOGF(fatal, "Efficiency-corrected multiplicity requires MultiplicitySelector::processTracks");
+    }


As this is anyway a transient table, I was wondering if instead of adding a new bool, one could use this feature to check the configuration of MultiplicitySelector:
https://github.com/AliceO2Group/O2Physics/blob/master/Common/Core/TableHelper.h#L71

This is a very nice solution, I have put it in

jgrosseo · 2026-09-11T11:27:05Z

+  using DerivedCollisionsMultSet = soa::Filtered<soa::Join<aod::CFCollisions, aod::CFMultSets>>;
+  using DerivedCollisionsMultSetCorrected = soa::Filtered<soa::Join<aod::CFCollisions, aod::CFCollisionsExtra, aod::CFMultSets>>;
  using DerivedTracks = soa::Filtered<aod::CFTracks>;
+  static constexpr int RequireRecoCollisionBestMode = 2;


Why not an enum for all 3 modes then?

… for passing configuration

EmilGorm · 2026-09-12T22:45:42Z

See my two comments.

What I find not good is that we have now a processMCEfficiency in correlations.cxx and in this task. I think we should only duplicate things which are strictly MPI related, while the efficiency improvements could also be useful for other analysis and I don't see any issue for others with your changes. What do you think?

Agreed, I have removed the processMCEfficiency from twoParticleCorrelationsMpi.cxx and moved the updates to correlations.cxx so it can remain the default task for processing efficiencies.

Please consider the following formatting changes to AliceO2Group#17783

alibuild · 2026-09-12T23:00:35Z

Error while checking build/O2Physics/code-check for a20c6a3 at 2026-09-13 13:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 89 warnings.'
Found 2 errors and 89 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/9684edee4d6b196ab2b19c7c688bf0c079cfdb43/O2Physics-code-check/errors.txt
PWGCF/Tasks/correlations.cxx:490:52: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationsMpi.cxx:42:1: error: included header StepTHn.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 89 -gt 0 ]]
++ cat /sw/BUILD/9684edee4d6b196ab2b19c7c688bf0c079cfdb43/O2Physics-code-check/warnings.txt
PWGCF/Tasks/correlations.cxx:76:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Tasks/correlations.cxx:89:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Tasks/correlations.cxx:91:8: warning: constructor does not initialize these fields: multCutFormulaParamIndex, ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Tasks/correlations.cxx:116:63: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Tasks/correlations.cxx:214:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:216:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:218:105: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:242:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:245:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Tasks/correlations.cxx:245:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:247:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Tasks/correlations.cxx:247:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:249:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Tasks/correlations.cxx:249:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:251:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Tasks/correlations.cxx:251:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:253:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Tasks/correlations.cxx:253:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:320:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:322:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:331:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:335:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:401:111: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:423:119: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:426:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:433:125: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:436:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:466:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:468:81: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:480:150: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:550:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:553:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:564:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:620:122: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:624:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:632:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:637:224: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Tasks/correlations.cxx:645:51: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Please consider the following formatting changes to AliceO2Group#17783

alibuild · 2026-09-13T12:53:03Z

Error while checking build/O2Physics/o2 for a20c6a3 at 2026-09-13 14:53:

## sw/BUILD/O2Physics-latest/log
2026-09-13T12:22:40.700+0200 [37352:140048619896448] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:22:40.701+0200 [37352:140048619896448] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:27:03.392+0200 [37352:140048619896448] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:27:29.576+0200 [37390:140003164544640] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:27:29.576+0200 [37390:140003164544640] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:38:56.072+0200 [37390:140003164544640] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:39:18.656+0200 [37418:140313332952704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:39:18.656+0200 [37418:140313332952704] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:43:42.251+0200 [37418:140313332952704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:44:08.990+0200 [37456:140552370142848] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:44:08.990+0200 [37456:140552370142848] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:46:37.438+0200 [37456:140552370142848] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:47:00.111+0200 [37484:140351215013504] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:47:00.111+0200 [37484:140351215013504] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:50:11.513+0200 [37484:140351215013504] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:50:36.566+0200 [37522:140595128712832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:50:36.566+0200 [37522:140595128712832] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:51:56.571+0200 [37522:140595128712832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:52:18.929+0200 [37550:139748562632320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:52:18.929+0200 [37550:139748562632320] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:54:18.937+0200 [37550:139748562632320] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:54:43.897+0200 [37588:139935447289472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:54:43.897+0200 [37588:139935447289472] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:56:43.905+0200 [37588:139935447289472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:57:06.443+0200 [37616:140708723646080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:57:06.444+0200 [37616:140708723646080] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T12:59:33.503+0200 [37616:140708723646080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:59:58.435+0200 [37654:139782689492608] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T12:59:58.435+0200 [37654:139782689492608] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:03:09.672+0200 [37654:139782689492608] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:03:31.937+0200 [37682:140571299466880] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:03:31.937+0200 [37682:140571299466880] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:05:31.946+0200 [37682:140571299466880] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:05:57.322+0200 [37720:140087110553216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:05:57.323+0200 [37720:140087110553216] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:10:04.921+0200 [37720:140087110553216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:10:27.787+0200 [37748:139904867565184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:10:27.787+0200 [37748:139904867565184] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:13:41.315+0200 [37748:139904867565184] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:14:07.007+0200 [37786:140020278255232] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:14:07.008+0200 [37786:140020278255232] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:16:34.188+0200 [37786:140020278255232] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:16:56.295+0200 [37814:140615321771648] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:16:56.295+0200 [37814:140615321771648] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:18:16.300+0200 [37814:140615321771648] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:18:41.765+0200 [37852:140187346873984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-09-13T13:18:41.766+0200 [37852:140187346873984] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-09-13T13:21:06.536+0200 [37852:140187346873984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
[0 more errors; see full log]

Full log here.

EmilGorm added 6 commits September 3, 2026 13:58

Add multiplicity corrected row to CFCollision table in CF derived data

d33f68c

move multiplicity-corrected multiplicity to dedicated CFCollisionsExt…

605567c

…ra table

Only use one reconstructed collision per generated collision in eff. …

a3fd837

…calculation

Add diagnostic histograms for MC efficiency

7ce4a4d

Add estimator type to CFMultiplicities table for task lookup

9ca2128

Use efficiency corrected multiplicity for dedicated processes

e70b10a

github-actions Bot added pwgcf datamodel labels Sep 5, 2026

github-actions Bot changed the title ~~Add efficiency-corrected multiplicity information to CF derived data~~ [PWGCF] Add efficiency-corrected multiplicity information to CF derived data Sep 5, 2026

linter fixes

ab8043d

EmilGorm marked this pull request as ready for review September 5, 2026 22:11

EmilGorm requested review from alibuild, dsarkaralice, jaelpark, jgrosseo, lauraser, victor-gonzalez and wenyaCern as code owners September 5, 2026 22:11

EmilGorm force-pushed the cf-multiplicity-corrected branch from f62a5a0 to 2e1d276 Compare September 7, 2026 07:28

code-check fixes

0d7ee15

EmilGorm force-pushed the cf-multiplicity-corrected branch from 2e1d276 to 0d7ee15 Compare September 7, 2026 12:06

alibuild mentioned this pull request Sep 7, 2026

Please consider the following formatting changes to #17783 EmilGorm/O2Physics#36

Merged

EmilGorm added a commit to EmilGorm/O2Physics that referenced this pull request Sep 7, 2026

Merge pull request #36 from alibuild/alibot-cleanup-17783

ed49bbc

Please consider the following formatting changes to AliceO2Group#17783

wenyaCern previously approved these changes Sep 9, 2026

View reviewed changes

wenyaCern enabled auto-merge (squash) September 9, 2026 07:30

EmilGorm dismissed wenyaCern’s stale review via ce13609 September 9, 2026 21:07

EmilGorm force-pushed the cf-multiplicity-corrected branch from ed49bbc to ce13609 Compare September 9, 2026 21:07

alibuild mentioned this pull request Sep 9, 2026

Please consider the following formatting changes to #17783 EmilGorm/O2Physics#37

Merged

Track multiplicity source and simplify efficiency lookup

788a441

EmilGorm force-pushed the cf-multiplicity-corrected branch from ce13609 to 788a441 Compare September 9, 2026 21:41

EmilGorm added a commit to EmilGorm/O2Physics that referenced this pull request Sep 9, 2026

Merge pull request #37 from alibuild/alibot-cleanup-17783

2b63f3b

Please consider the following formatting changes to AliceO2Group#17783

codecheck

094c22e

EmilGorm force-pushed the cf-multiplicity-corrected branch from 2b63f3b to 094c22e Compare September 10, 2026 11:22

alibuild mentioned this pull request Sep 10, 2026

Please consider the following formatting changes to #17783 EmilGorm/O2Physics#38

Merged

EmilGorm added a commit to EmilGorm/O2Physics that referenced this pull request Sep 10, 2026

Merge pull request #38 from alibuild/alibot-cleanup-17783

59c52bf

Please consider the following formatting changes to AliceO2Group#17783

jgrosseo reviewed Sep 11, 2026

View reviewed changes

move processMCEfficiency changes to correlations.cxx, use tablehelper…

87c6b02

… for passing configuration

EmilGorm force-pushed the cf-multiplicity-corrected branch from 59c52bf to 87c6b02 Compare September 12, 2026 22:29

alibuild mentioned this pull request Sep 12, 2026

Please consider the following formatting changes to #17783 EmilGorm/O2Physics#39

Merged

linter

502094c

EmilGorm added a commit to EmilGorm/O2Physics that referenced this pull request Sep 12, 2026

Merge pull request #39 from alibuild/alibot-cleanup-17783

a20c6a3

Please consider the following formatting changes to AliceO2Group#17783

codecheck

e9813f8

EmilGorm force-pushed the cf-multiplicity-corrected branch from a20c6a3 to e9813f8 Compare September 13, 2026 11:32

Please consider the following formatting changes

9712d02

alibuild mentioned this pull request Sep 13, 2026

Please consider the following formatting changes to #17783 EmilGorm/O2Physics#40

Merged

EmilGorm added 2 commits September 13, 2026 13:33

Merge pull request #40 from alibuild/alibot-cleanup-17783

85fe6b1

Please consider the following formatting changes to AliceO2Group#17783

Merge branch 'master' into cf-multiplicity-corrected

b34d30b

jgrosseo approved these changes Sep 14, 2026

View reviewed changes

wenyaCern approved these changes Sep 14, 2026

View reviewed changes

wenyaCern merged commit 5863b59 into AliceO2Group:master Sep 14, 2026
15 checks passed

EmilGorm deleted the cf-multiplicity-corrected branch September 14, 2026 08:36

Navigation Menu

Uh oh!

[PWGCF] Add efficiency-corrected multiplicity information to CF derived data - #17783

[PWGCF] Add efficiency-corrected multiplicity information to CF derived data#17783
wenyaCern merged 16 commits into
AliceO2Group:masterfrom
EmilGorm:cf-multiplicity-corrected

EmilGorm commented Sep 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

alibuild commented Sep 5, 2026

Uh oh!

alibuild commented Sep 6, 2026

Uh oh!

alibuild commented Sep 7, 2026

Uh oh!

alibuild commented Sep 10, 2026 •

edited

Loading

Uh oh!

jgrosseo left a comment

Uh oh!

jgrosseo Sep 11, 2026

Uh oh!

EmilGorm Sep 12, 2026

Uh oh!

jgrosseo Sep 11, 2026

Uh oh!

EmilGorm Sep 12, 2026

Uh oh!

EmilGorm commented Sep 12, 2026

Uh oh!

alibuild commented Sep 12, 2026 •

edited

Loading

Uh oh!

alibuild commented Sep 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

EmilGorm commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 5, 2026

Uh oh!

alibuild commented Sep 6, 2026

Uh oh!

alibuild commented Sep 7, 2026

Uh oh!

alibuild commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgrosseo left a comment

Choose a reason for hiding this comment

Uh oh!

jgrosseo Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

EmilGorm Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

jgrosseo Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

EmilGorm Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

EmilGorm commented Sep 12, 2026

Uh oh!

alibuild commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

EmilGorm commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

alibuild commented Sep 10, 2026 •

edited

Loading

alibuild commented Sep 12, 2026 •

edited

Loading