Skip to content

[PWGHF] Add EMCal-registered event selection for hadrons in event mixing - #17741

Open
rashigupt wants to merge 31 commits into
AliceO2Group:masterfrom
rashigupt:rashi
Open

[PWGHF] Add EMCal-registered event selection for hadrons in event mixing#17741
rashigupt wants to merge 31 commits into
AliceO2Group:masterfrom
rashigupt:rashi

Conversation

@rashigupt

@rashigupt rashigupt commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This update adds the EMCal-registered event selection when filling the hadron table used for event mixing in CorrelatorHfehadron.cxx. This ensures that only hadrons from EMCal-registered events are included in the mixed-event correlation analysis.

rashi234 and others added 29 commits March 23, 2026 19:34
@rashi234
Add histograms for Non-HFE analysis
657760c
@rashigupt
Correct Pass emcal histogram
ade7132
@rashigupt
Merge branch 'AliceO2Group:master' into rashi
8f850a4
@rashigupt
Add some variables in electron selection table
b856609
@rashigupt
Add MC-based efficiency calculation and new variables to electron sel…
c38be3f 
…ection table

Introduce MC changes for efficiency estimation and extend electron selection table with additional variables
@rashigupt
Adding variables to the electron–hadron correlation table.
844c912
@rashigupt
Adding variables to the electron–hadron correlation table.
f4712f2
@rashigupt
Remove formate error
5b431e9
@rashigupt
remove O2linter error
dd9880b
@rashigupt
Remove build error
834c9b5
@rashigupt
Remove build error
c787157
@rashigupt
Remove build error
ad748e7
@rashigupt
Remove build error
9834e24
@rashigupt
Remove formate error
612fc0e
@rashigupt
Update CorrelationTables.h
c584738
@rashigupt
Used getcharmHadron Function
ce98b5c 
Used getcharmHadron Function
@rashigupt
Update electronSelectionWithTpcEmcal.cxx
8efe0a5
@rashigupt
Add Event mixing task
3c1a8a3
@rashigupt
Merge branch 'master' into rashi
9897606
@rashigupt
correct eop and mo2 in table
04ff736
@rashigupt
remove clang error
81cb653
@rashigupt
remove linter erro
284788b
@rashigupt
remove clang error
0676d7e
@rashigupt
Update Hadron table for Offline Event Mixing
5a5b52e
@rashigupt
remove offline event mixing
2c875fa
@rashigupt
Merge branch 'AliceO2Group:master' into rashi
62abacd
@rashigupt
Add high pt cut on mcgen
9ff65bb
@rashigupt
Merge branch 'AliceO2Group:master' into rashi
8ea2a08
@rashigupt
Add EMCal-registered event selection for hadrons in event mixing
655e3b0 
Add EMCal-registered event selection for hadrons in event mixing
@rashigupt
rashigupt requested a review from alibuild as a code owner September 3, 2026 04:32
@github-actions github-actions Bot added the pwghf PWG-HF label Sep 3, 2026
@github-actions github-actions Bot changed the title Add EMCal-registered event selection for hadrons in event mixing [PWGHF] Add EMCal-registered event selection for hadrons in event mixing Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 655e3b0 at 2026-09-03 11:30:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 655e3b0 at 2026-09-04 01:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/31fb27c457cb089657ce2691db25a824f439791d/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:288:9: error: variable 'cntEle' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:302:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@rashigupt

rashigupt commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Dear Expert, the code builds successfully on my local machine.

@vkucera

vkucera commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Dear Expert, the code builds successfully on my local machine.

You still have a compilation warning.

@rashigupt
Remove Warning
a97a334 
Remove Cntele warning
@alibuild

alibuild commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a97a334 at 2026-09-08 03:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/45aa122dc4712ae78ea55c45156a4963db00f77b/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx:301:45: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@rashigupt

rashigupt commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Dear expert , please approve and merge the code.

@rashigupt

rashigupt commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Dear experts,
If there are no further comments or suggestions, could you please approve and merge the code?
Thank you for your time.

vkucera
vkucera reviewed Sep 9, 2026
View reviewed changes
Comment thread PWGHF/HFC/TableProducer/correlatorHfeHadrons.cxx Outdated
@alibuild

alibuild commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f49c302 at 2026-09-11 10:59:

No log files found

Full log here.

@rashigupt

rashigupt commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

Dear experts,
If there are no further comments or suggestions, could you please approve and merge the code?
Thank you for your time

1 similar comment
@rashigupt

rashigupt commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Dear experts,
If there are no further comments or suggestions, could you please approve and merge the code?
Thank you for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rashigupt @alibuild @vkucera @rashi234