Skip to content

[Trigger,PWGCF,PWGEM,PWGLF,PWGUD] Use const& and std::move to avoid copies - #17705

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-EventFiltering
Open

[Trigger,PWGCF,PWGEM,PWGLF,PWGUD] Use const& and std::move to avoid copies#17705
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:const-EventFiltering

Conversation

@vkucera

@vkucera vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Mostly done automatically by Clang-Tidy.

@vkucera
Use const& and std::move to avoid copies
c325a9d 
Mostly done automatically by Clang-Tidy.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 184 errors, ⚠️ 167 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Use const& and std::move to avoid copies [Trigger,PWGCF,PWGEM,PWGLF,PWGUD] Use const& and std::move to avoid copies Sep 1, 2026
@vkucera
vkucera marked this pull request as ready for review September 1, 2026 15:53
@alibuild

alibuild commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c325a9d at 2026-09-15 10:03:

No log files found

Full log here.

@vkucera

vkucera commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Ping

@alibuild

alibuild commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c325a9d at 2026-09-10 02:28:

## sw/BUILD/O2Physics-latest/log
2026-09-10T02:26:32.631+0200 [38:140223373655680] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.642+0200 [38:140223373655680] [executioncontext.cpp:739] [ERROR] Failed to download output blob 093af89b301400740ca6b7bd7b4f89be18702bcf979d6974171bc3d0d951c8e9: 14: Socket closed
2026-09-10T02:26:32.631+0200 [25:139674761895552] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.644+0200 [25:139674761895552] [executioncontext.cpp:739] [ERROR] Failed to download output blob b4d7728d5a4c8529cf7de4d6aae986d6498929dd739f813c551cc49cd8bf741e: 14: Socket closed
2026-09-10T02:26:32.631+0200 [23:140146076491392] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.646+0200 [23:140146076491392] [executioncontext.cpp:739] [ERROR] Failed to download output blob 4ec595e85f8c02e04c26c8fe7373259fb01fbf9a4caed7cd04dfe1ec59a5394a: 14: Socket closed
2026-09-10T02:26:32.631+0200 [29:139877730696832] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.643+0200 [29:139877730696832] [executioncontext.cpp:739] [ERROR] Failed to download output blob 388d9ed16b3d7e23b24bdeeb2528332752a728b2f226e927623a6b340b9c4161: 14: Socket closed
2026-09-10T02:26:32.632+0200 [32:139842939252352] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.649+0200 [32:139842939252352] [executioncontext.cpp:739] [ERROR] Failed to download output blob 7d960b03a996f843a57c4578136d313b69641762bbe5a86d8769cd4081e0ad0f: 14: Socket closed
2026-09-10T02:26:32.631+0200 [36:140162878197376] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.649+0200 [36:140162878197376] [executioncontext.cpp:739] [ERROR] Failed to download output blob a9ddaadec0dfa1019c8ed27e974cf5cc0f6969fb0415a089f2fbe0f781f70ae2: 14: Socket closed
2026-09-10T02:26:32.631+0200 [30:139775835864704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.652+0200 [30:139775835864704] [executioncontext.cpp:739] [ERROR] Failed to download output blob a2bc56d7123c16bec835250b4e89406d660f16bd2588c32de783d5b67b8c2fee: 14: Socket closed
2026-09-10T02:26:32.632+0200 [35:140096626675328] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: recvmsg:Connection reset by peer]
2026-09-10T02:26:32.666+0200 [35:140096626675328] [executioncontext.cpp:739] [ERROR] Failed to download output blob b9dae39e1851ec51bdcbc634f315b9163e789e4ed4b287ac705ea03e37dfdc3b: 14: recvmsg:Connection reset by peer
2026-09-10T02:26:32.631+0200 [39:139792113262208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.663+0200 [39:139792113262208] [executioncontext.cpp:739] [ERROR] Failed to download output blob 1d82e9174fab12d334eb4be6ec84c680cf31164e2047fe9cca3a4f6feff5be6b: 14: Socket closed
2026-09-10T02:26:32.632+0200 [42:140384907673216] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.657+0200 [42:140384907673216] [executioncontext.cpp:739] [ERROR] Failed to download output blob 9c17ab816e0f951b89e4d01c5132ee7212e068df2101cb82124242d3e0b6f525: 14: Socket closed
2026-09-10T02:26:32.631+0200 [28:139645463559808] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.667+0200 [28:139645463559808] [executioncontext.cpp:739] [ERROR] Failed to download output blob a2a28d85ef99a7d46002d7eaf3f77b0fb2cc94e37671ba622a0bc5982251d872: 14: Socket closed
2026-09-10T02:26:32.631+0200 [40:140352442924672] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-09-10T02:26:32.663+0200 [40:140352442924672] [executioncontext.cpp:739] [ERROR] Failed to download output blob 6e08def2781f294543fcf5b4cd533acc605b773f6b40fb2bb93ce9dcc8b973e6: 14: Socket closed
2026-09-10T02:26:33.315+0200 [523:139935131303552] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-10T02:26:33.316+0200 [523:139935131303552] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-09-10T02:26:34.881+0200 [578:139884944805504] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-09-10T02:26:34.881+0200 [578:139884944805504] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
ninja: build stopped: subcommand failed.

Full log here.

@vkucera

vkucera commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Ping 2

@vkucera

vkucera commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Ping 3

@vkucera

vkucera commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

Dear @ariedel-cern @ChiaraDeMartin95 @dsekihat @ercolessi @fgrosa @lauraser @lietava @mpuccio @nstrangm @pbuehler This PR has been opened for two weeks with no review. Is there a problem?

@ariedel-cern

ariedel-cern commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Hi @vkucera , many thanks for the PR. The changes in CF trigger seem good to me. Same with the changes made to the macros.

@vkucera

vkucera commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @vkucera , many thanks for the PR. The changes in CF trigger seem good to me. Same with the changes made to the macros.

Thanks @ariedel-cern , can you approve the PR then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@nstrangm nstrangm Awaiting requested review from nstrangm nstrangm is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@lietava lietava Awaiting requested review from lietava lietava is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95 ChiaraDeMartin95 is a code owner
@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgcf pwgem pwglf pwgud trigger

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkucera @alibuild @ariedel-cern