[PWGCF] Efficiency Correction Added using CCDB Histograms - #17533
Open
rahulverma012 wants to merge 10 commits into
Open
rahulverma012 wants to merge 10 commits into
rahulverma012 wants to merge 10 commits into
Conversation
Code now contains parts related to efficiency correction implement using the Histograms stored in CCDB
rahulverma012
requested review from
SwatiSaha-1997,
alibuild,
dsarkaralice,
isputows,
lauraser and
victor-gonzalez
as code owners
August 21, 2026 02:08
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
rahulverma012
marked this pull request as draft
August 21, 2026 02:21
Updated function signatures to use const references for string parameters and vector parameters.
rahulverma012
marked this pull request as ready for review
August 21, 2026 04:02
Collaborator
|
Error while checking build/O2Physics/staging for 6b682ec at 2026-08-21 08:23: Full log here. |
Comment out unused constants and arrays for clarity.
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for ab1a41e at 2026-08-31 21:24: Full log here. |
Collaborator
|
Dear @rahulverma012 , could you please fix the code-check failure errors in your code and update the PR? I can approve it after that. |
vkucera
reviewed
Aug 31, 2026
Comment on lines
+215
to
+221
| kPrimTrkPhi1020 = 0, | ||
| kPrimTrkJPsiToEE, | ||
| kPrimTrkJPsiToMuMu, | ||
| kPrimTrkKStar892, | ||
| kPrimTrkKStar892Bar, | ||
| kPrimTrkRho770, | ||
| primVtxTrkEnumSize |
Collaborator
There was a problem hiding this comment.
Follow naming conventions, i.e. UpperCamelCase and no k prefix.
vkucera
reviewed
Aug 31, 2026
rahulverma012
marked this pull request as draft
September 10, 2026 05:57
Collaborator
|
Error while checking build/O2Physics/code-check for 01f01cc at 2026-09-10 09:43: Full log here. |
rahulverma012
marked this pull request as ready for review
September 15, 2026 08:17
Contributor
Author
|
Dear @SwatiSaha-1997 and @vkucera, I have removed all the errors and warnings. Best Regards, |
vkucera
reviewed
Sep 15, 2026
|
|
||
| namespace o2::aod | ||
| { | ||
| using Collision = aod::Collisions::iterator; |
Collaborator
There was a problem hiding this comment.
This is wrong. Collision is already defined in the main data model.
vkucera
reviewed
Sep 15, 2026
Comment on lines
+188
to
+190
| static constexpr std::array<double, 19> DoublePowersOf10 = { | ||
| 1e0, 1e1, 1e2, 1e3, 1e4, 1e5, 1e6, 1e7, 1e8, 1e9, | ||
| 1e10, 1e11, 1e12, 1e13, 1e14, 1e15, 1e16, 1e17, 1e18}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code now contains parts related to efficiency correction implemented using the Histograms stored in CCDB.