[PWGHF] treeCreatorLcToPKPi: check the size of HfMlLcToPKPi#16425
Open
lubynets wants to merge 1 commit into
Open
[PWGHF] treeCreatorLcToPKPi: check the size of HfMlLcToPKPi#16425lubynets wants to merge 1 commit into
lubynets wants to merge 1 commit into
Conversation
lubynets
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of the code if
applyMl== true and the sizes of tables with candidates and theaod::HfMlLcToPKPiare not equal (e.g.applyMlwas not enabled in thecandidateSelectorLc), the code crashes via segmentation error because of dereferencing the nullptr. (The reason why mentioned tables are not joined is discussed here).This PR adds a function which checks the mentioned sizes for equality and throws a
fatalerror in case of fail.