[PWGLF] Add tree producer for coalescence studies#16390
Merged
Conversation
alcaliva
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
|
O2 linter results: ❌ 1 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 2d26eee at 2026-05-26 11:48: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 2d26eee at 2026-05-26 11:48: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 7ea2771 at 2026-05-26 12:00: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 7ea2771 at 2026-05-26 12:02: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 4ab91f7 at 2026-05-26 12:08: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 4ab91f7 at 2026-05-26 12:12: Full log here. |
maciacco
approved these changes
May 26, 2026
vkucera
reviewed
May 27, 2026
Comment on lines
+31
to
+37
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/Configurable.h" | ||
| #include "Framework/HistogramRegistry.h" | ||
| #include "Framework/InitContext.h" | ||
| #include "Framework/Logger.h" | ||
| #include "Framework/OutputObjHeader.h" | ||
| #include "Framework/runDataProcessing.h" |
Collaborator
vkucera
reviewed
May 27, 2026
Comment on lines
+87
to
+89
| static constexpr double MassP = o2::constants::physics::MassProton; | ||
| static constexpr double MassN = o2::constants::physics::MassNeutron; | ||
| static constexpr double MassL = o2::constants::physics::MassLambda0; |
vkucera
reviewed
May 27, 2026
Comment on lines
+76
to
+85
| int64_t eventID; // Event ID | ||
| int64_t idB1, idB2, idB3; // MC particle IDs of the constituent baryons | ||
|
|
||
| int pdgB1, pdgB2, pdgB3; | ||
| int chargeB1, chargeB2, chargeB3; | ||
|
|
||
| // Space-time coordinates and momentum components of the constituent baryons in the lab frame | ||
| float xB1, yB1, zB1, tB1, pxB1, pyB1, pzB1; | ||
| float xB2, yB2, zB2, tB2, pxB2, pyB2, pzB2; | ||
| float xB3, yB3, zB3, tB3, pxB3, pyB3, pzB3; |
Collaborator
There was a problem hiding this comment.
Everything uninitialised.
vkucera
reviewed
May 27, 2026
Comment on lines
+92
to
+102
| int64_t id; | ||
| int pdg; | ||
| int charge; | ||
| float x; | ||
| float y; | ||
| float z; | ||
| float t; | ||
| float px; | ||
| float py; | ||
| float pz; | ||
| float mass; |
Collaborator
There was a problem hiding this comment.
Everything uninitialised.
vkucera
reviewed
May 27, 2026
Comment on lines
+183
to
+184
| template <typename T> | ||
| Particle makeParticle(T const& p) |
Collaborator
There was a problem hiding this comment.
Why is this not a Particle constructor?
Collaborator
Author
|
Hi @vkucera , thanks for your comments. I'm going to fix this task asap. |
bhattdurgesh921-sys
pushed a commit
to bhattdurgesh921-sys/O2Physics
that referenced
this pull request
May 28, 2026
vkucera
reviewed
Jun 1, 2026
Comment on lines
+325
to
+328
| if (pRho.R() > pRhoMax) { | ||
| return false; | ||
| } | ||
| return true; |
Collaborator
There was a problem hiding this comment.
This could simply be return pRho.R() <= pRhoMax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree producer to store space-time coordinates and momentum components of bound-state candidates for coalescence studies