[PWGEM] Adding histograms for accepted pi0 and eta into gamma gamma decay cha…#15465
Draft
amaringarcia wants to merge 1 commit intoAliceO2Group:masterfrom
Draft
[PWGEM] Adding histograms for accepted pi0 and eta into gamma gamma decay cha…#15465amaringarcia wants to merge 1 commit intoAliceO2Group:masterfrom
amaringarcia wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
amaringarcia
requested review from
alibuild,
dsekihat,
jokonig,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
github-actions
bot
changed the title
| auto lDaughter0 = lDaughters.begin(); | ||
| if (lNDaughters == 2) { | ||
| auto lDaughter1 = lDaughters.iteratorAt(1); | ||
| if ( std::fabs(lDaughter0.eta())< cfg_max_eta_photon && std::fabs(lDaughter1.eta()) < cfg_max_eta_photon){ |
Collaborator
There was a problem hiding this comment.
Maybe we can add a proper function to make the acceptance checks to allow the check for the different photon detection methods? So we can have comparable acceptance between Run2 and Run3
Comment on lines
+180
to
+182
| auto lDaughter0 = lDaughters.begin(); | ||
| if (lNDaughters == 2) { | ||
| auto lDaughter1 = lDaughters.iteratorAt(1); |
Collaborator
There was a problem hiding this comment.
Spawning iterators all the time in the loop is very expensive. One should create two iterators once before the loop and use setCursor(index) instead to move the iterator to the correct position.
| if ((mcParticle.isPhysicalPrimary() || mcParticle.producedByGenerator()) && std::fabs(mcParticle.y()) < 0.9f && mcParticle.pt() < 20.f) { | ||
| auto binNumber = hBinFinder->FindBin(mcParticle.pt(), std::fabs(mcParticle.y())); // caution: pack | ||
| size_t lNDaughters = 0; | ||
| size_t mesonAccepted = 0; |
Collaborator
There was a problem hiding this comment.
This is currently used as a bool, please check if this is the intended use. If so, might be best to rename it to isMesonAccepted and make it a bool for clarity.
Collaborator
|
@amaringarcia Please check your changes for formatting before you open a PR for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nnel
BinnedAcceptedPi0/Eta are not stored