Skip to content

[PWGUD] Fix ambiguous-track BC handling in UPCCandProducer #15463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ariffero wants to merge 4 commits into
base: master
Choose a base branch
from
+40 −12
Draft

[PWGUD] Fix ambiguous-track BC handling in UPCCandProducer #15463

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d368c23
Fix ambiguous-track BC handling in UPCCandProducer
ariffero Mar 19, 2026
2d2557b
Add Andrea Riffero as author of UPCCandidateProducer
ariffero Mar 19, 2026
be24acb
Please consider the following formatting changes
alibuild Mar 20, 2026
b47ea6c
Merge pull request #14 from alibuild/alibot-cleanup-15463
ariffero Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 40 additions & 12 deletions PWGUD/TableProducer/UPCCandidateProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
/// \author Nazar Burmasov, nazar.burmasov@cern.ch
/// \author Diana Krupova, diana.krupova@cern.ch
/// \since 04.06.2024
/// \author Andrea Riffero, andrea.giovanni.riffero@cern.ch
/// \since 19.03.2026

#include "PWGUD/Core/UPCCutparHolder.h"
#include "PWGUD/Core/UPCHelpers.h"
Expand Down Expand Up @@ -603,17 +605,25 @@ struct UpcCandProducer {
// "uncorrected" bcs
template <int32_t tracksSwitch, typename TBCs, typename TAmbTracks>
void collectAmbTrackBCs(std::unordered_map<int64_t, uint64_t>& ambTrIds,
TBCs const& bcs,
TAmbTracks ambTracks)
{
for (const auto& ambTrk : ambTracks) {
auto trkId = getAmbTrackId<tracksSwitch>(ambTrk);
const auto& bcSlice = ambTrk.template bc_as<TBCs>();
uint64_t trackBC = -1;
if (bcSlice.size() != 0) {
auto first = bcSlice.begin();
trackBC = first.globalBC();

const auto& bcIds = ambTrk.bcIds();
if (bcIds.size() == 0)
continue;

const auto firstBcId = static_cast<int64_t>(*bcIds.begin());
if (firstBcId < 0 || firstBcId >= static_cast<int64_t>(bcs.size())) {
LOGP(debug,
"Skipping ambiguous track {}: invalid first bcId {} (nBCs = {})",
trkId, firstBcId, bcs.size());
continue;
}
ambTrIds[trkId] = trackBC;

ambTrIds[trkId] = bcs.iteratorAt(firstBcId).globalBC();
}
}

Expand Down Expand Up @@ -649,16 +659,22 @@ struct UpcCandProducer {
continue;
int64_t trkId = trk.globalIndex();
int32_t nContrib = -1;
bool hasTrackBC = false;
uint64_t trackBC = 0;
if (trk.has_collision()) {
const auto& col = trk.collision();
nContrib = col.numContrib();
trackBC = col.bc_as<TBCs>().globalBC();
hasTrackBC = true;
} else {
auto ambIter = ambBarrelTrBCs.find(trkId);
if (ambIter != ambBarrelTrBCs.end())
if (ambIter != ambBarrelTrBCs.end()) {
trackBC = ambIter->second;
hasTrackBC = true;
}
}
if (!hasTrackBC)
continue;
int64_t tint = TMath::FloorNint(trk.trackTime() / o2::constants::lhc::LHCBunchSpacingNS + static_cast<float>(fBarrelTrackTShift));
uint64_t bc = trackBC + tint;
if (nContrib > upcCuts.getMaxNContrib())
Expand All @@ -683,15 +699,22 @@ struct UpcCandProducer {
continue;
int64_t trkId = trk.globalIndex();
int32_t nContrib = -1;
bool hasTrackBC = false;
uint64_t trackBC = 0;
auto ambIter = ambFwdTrBCs.find(trkId);
if (ambIter == ambFwdTrBCs.end()) {
if (!trk.has_collision())
continue;
const auto& col = trk.collision();
nContrib = col.numContrib();
trackBC = col.bc_as<TBCs>().globalBC();
hasTrackBC = true;
} else {
trackBC = ambIter->second;
hasTrackBC = true;
}
if (!hasTrackBC)
continue;
int64_t tint = TMath::FloorNint(trk.trackTime() / o2::constants::lhc::LHCBunchSpacingNS + static_cast<float>(fMuonTrackTShift));
uint64_t bc = trackBC + tint;
if (nContrib > upcCuts.getMaxNContrib())
Expand All @@ -716,9 +739,12 @@ struct UpcCandProducer {
continue;
int64_t trkId = trk.globalIndex();
int32_t nContrib = -1;
bool hasTrackBC = false;
uint64_t trackBC = 0;
auto ambIter = ambFwdTrBCs.find(trkId);
if (ambIter == ambFwdTrBCs.end()) {
if (!trk.has_collision())
continue;
const auto& col = trk.collision();
nContrib = col.numContrib();
trackBC = col.bc_as<TBCs>().globalBC();
Expand All @@ -732,6 +758,8 @@ struct UpcCandProducer {
} else {
trackBC = ambIter->second;
}
if (!hasTrackBC)
continue;
int64_t tint = TMath::FloorNint(trk.trackTime() / o2::constants::lhc::LHCBunchSpacingNS + static_cast<float>(fMuonTrackTShift));
uint64_t bc = trackBC + tint;
if (nContrib > upcCuts.getMaxNContrib())
Expand Down Expand Up @@ -800,7 +828,7 @@ struct UpcCandProducer {
// trackID -> index in amb. track table
std::unordered_map<int64_t, uint64_t> ambBarrelTrBCs;
if (upcCuts.getAmbigSwitch() != 1)
collectAmbTrackBCs<0, BCsWithBcSels>(ambBarrelTrBCs, ambBarrelTracks);
collectAmbTrackBCs<0, BCsWithBcSels>(ambBarrelTrBCs, bcs, ambBarrelTracks);

collectBarrelTracks(bcsMatchedTrIdsTOF,
0,
Expand Down Expand Up @@ -1101,10 +1129,10 @@ struct UpcCandProducer {

// trackID -> index in amb. track table
std::unordered_map<int64_t, uint64_t> ambBarrelTrBCs;
collectAmbTrackBCs<0, BCsWithBcSels>(ambBarrelTrBCs, ambBarrelTracks);
collectAmbTrackBCs<0, BCsWithBcSels>(ambBarrelTrBCs, bcs, ambBarrelTracks);

std::unordered_map<int64_t, uint64_t> ambFwdTrBCs;
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, ambFwdTracks);
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, bcs, ambFwdTracks);

collectForwardTracks(bcsMatchedTrIdsMID,
o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack,
Expand Down Expand Up @@ -1301,7 +1329,7 @@ struct UpcCandProducer {

// trackID -> index in amb. track table
std::unordered_map<int64_t, uint64_t> ambFwdTrBCs;
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, ambFwdTracks);
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, bcs, ambFwdTracks);

collectForwardTracks(bcsMatchedTrIdsMID,
o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack,
Expand Down Expand Up @@ -1556,7 +1584,7 @@ struct UpcCandProducer {

// trackID -> index in amb. track table
std::unordered_map<int64_t, uint64_t> ambFwdTrBCs;
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, ambFwdTracks);
collectAmbTrackBCs<1, BCsWithBcSels>(ambFwdTrBCs, bcs, ambFwdTracks);

collectForwardTracks(bcsMatchedTrIdsMID,
o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack,
Expand Down
Loading