[PWGHF] Implement TPC pid for light nuclei based on Bethe-Bloch parametrization in HF track skimming task #14729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
zhangbiao-phy
changed the title
github-actions
bot
changed the title
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano and
vkucera
as code owners
vkucera
requested changes
Feb 1, 2026
PWGHF/Core/SelectorCuts.h
Outdated
| {-4, 3, 5., 0., 100, 100, 0.83, 160., 1.}, | ||
| {-4, 3, 5., 0., 100, 100, 0.83, 160., 1.}}; | ||
| static const std::vector<std::string> labelsCutsTrack = {"nSigmaMinIts", "minItsClusterSizes", "minItsCluster", "minItsIbCluster", "minTpcCluster", "minTpcRow", "minTpcCrossedOverFound", "maxTpcShared", "maxTpcFracShared"}; | ||
| constexpr float CutsTrackQuality[3][10] = {{-4, 3, 5., 0., 100, 100, 0.83, 160., 1., 5}, |
Collaborator
There was a problem hiding this comment.
I already commented on this many times before. Do not hard-code array dimensions.
PWGHF/Core/SelectorCuts.h
Outdated
| {-4, 3, 5., 0., 100, 100, 0.83, 160., 1.}, | ||
| {-4, 3, 5., 0., 100, 100, 0.83, 160., 1.}}; | ||
| static const std::vector<std::string> labelsCutsTrack = {"nSigmaMinIts", "minItsClusterSizes", "minItsCluster", "minItsIbCluster", "minTpcCluster", "minTpcRow", "minTpcCrossedOverFound", "maxTpcShared", "maxTpcFracShared"}; | ||
| constexpr float CutsTrackQuality[3][10] = {{-4, 3, 5., 0., 100, 100, 0.83, 160., 1., 5}, |
Collaborator
There was a problem hiding this comment.
You are initialising float elements with a mixture of int and double values.
PWGHF/Core/SelectorCuts.h
Outdated
| static const std::vector<std::string> labelsCutsTrack = {"nSigmaMinIts", "minItsClusterSizes", "minItsCluster", "minItsIbCluster", "minTpcCluster", "minTpcRow", "minTpcCrossedOverFound", "maxTpcShared", "maxTpcFracShared", "maxTPCnSigmaBB"}; | ||
| static const std::vector<std::string> labelsRowsNucleiType = {"Deutron", "Triton", "Helium3"}; | ||
|
|
||
| constexpr float BetheBlochParams[3][6] = {{5.39302, 7.859534, 0.004048, 2.323197, 1.609307, 0.09}, |
Collaborator
There was a problem hiding this comment.
Do not hard-code array dimensions.
| #include "Common/DataModel/TrackSelectionTables.h" | ||
| #include "Tools/ML/MlResponse.h" | ||
|
|
||
| #include "MathUtils/BetheBlochAleph.h" |
|
|
||
| // CharmNuclei track selection | ||
| Configurable<LabeledArray<float>> selectionsLightNuclei{"selectionsLightNuclei", {hf_presel_lightnuclei::CutsTrackQuality[0], 3, 9, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsCutsTrack}, "nuclei track selections for deuteron / triton / helium applied if proper process function enabled"}; | ||
| Configurable<LabeledArray<float>> selectionsLightNuclei{"selectionsLightNuclei", {hf_presel_lightnuclei::CutsTrackQuality[0], 3, 10, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsCutsTrack}, "nuclei track selections for deuteron / triton / helium applied if proper process function enabled"}; |
Collaborator
There was a problem hiding this comment.
Do not hard-code array dimensions.
| // CharmNuclei track selection | ||
| Configurable<LabeledArray<float>> selectionsLightNuclei{"selectionsLightNuclei", {hf_presel_lightnuclei::CutsTrackQuality[0], 3, 9, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsCutsTrack}, "nuclei track selections for deuteron / triton / helium applied if proper process function enabled"}; | ||
| Configurable<LabeledArray<float>> selectionsLightNuclei{"selectionsLightNuclei", {hf_presel_lightnuclei::CutsTrackQuality[0], 3, 10, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsCutsTrack}, "nuclei track selections for deuteron / triton / helium applied if proper process function enabled"}; | ||
| Configurable<LabeledArray<float>> tpcPidBBParamsLightNuclei{"tpcPidBBParamsLightNuclei", {hf_presel_lightnuclei::BetheBlochParams[0], 3, 6, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsBetheBlochParams}, |
Collaborator
There was a problem hiding this comment.
Do not hard-code array dimensions.
Comment on lines
1691
to
1692
| default: | ||
| return false; |
Collaborator
There was a problem hiding this comment.
Is this a valid scenario or an error?
Collaborator
Author
There was a problem hiding this comment.
error, I add an LOG(fatal) there now
| const float maxTpcFracShared = config.selectionsLightNuclei->get(row, 8u); | ||
|
|
||
| // Optional: BB-based TPC nσ selection (only if enabled) | ||
| const float maxTPCnSigmaBB = config.selectionsLightNuclei->get(row, 9u); |
Collaborator
There was a problem hiding this comment.
max is not a quantity. Follow naming conventions.
Comment on lines
1781
to
1784
| // Mass/charge hypothesis for the selected nucleus. | ||
| const double mass = | ||
| (lightnuclei == ChannelsNucleiQA::Deuteron) ? MassDeuteron : (lightnuclei == ChannelsNucleiQA::Triton) ? MassTriton | ||
| : MassHelium3; |
Collaborator
There was a problem hiding this comment.
Do not nest ternary operators. A switch statement or a function would be much better.
Comment on lines
1856
to
1857
| ChannelsNucleiQA nucleiType = | ||
| (iDecay3P == hf_cand_3prong::DecayType::CdToDeKPi) ? ChannelsNucleiQA::Deuteron : (iDecay3P == hf_cand_3prong::DecayType::CtToTrKPi) ? ChannelsNucleiQA::Triton |
Collaborator
There was a problem hiding this comment.
Do not nest ternary operators. A switch statement or a function would be much better.
Collaborator
Author
|
thanks @vkucera! I fixed your comments now, please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fgrosa, the BB parametrization is validated with two diffrent analysis of LF