Refactor of anchor configuration logic#1966
Conversation
This commit refactors the transfer of anchoring configuration from
async-reco scripts into the MC pipeline, addressing O2-5011 by
replacing the previous whitelisting mechanism with a blacklisting approach.
In addition, it introduces broader configuration/customization support:
users can now inject arbitrary command-line options into any task
via a `customize.json` file, reducing the need to edit workflow scripts.
For example:
{
"ConfigParams": {
"EMCSimParam": {
"mBusyTime": "11.11"
}
},
"Executables": {
"o2-ft0-reco-workflow": {
"filtered": {
"--my-custom-option": "foo"
}
},
"ft0fv0emcctp_digi": {
"filtered": {
"--another-custom-option": "baz"
}
}
}
}
This allows for flexible injection of both configKeyValues and CLI options
via `o2dpg_sim_workflow.py --overwrite-config customize.json`.
This task seems no longer needed.
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
@shahor02 : Proposal for the blacklisting refactor. We will now pickup things like We still need to do some final adjustments, proper testing, and the treatment for TPC distortions. For now WIP. |
|
@sawenzel thanks, looks nice! (did not dive into the implementation details) |
807d610 to
b0255d0
Compare
| ALIEN_JDL_LPMPRODUCTIONTAG=$ALIEN_JDL_LPMANCHORPRODUCTION | ||
|
|
||
| if [[ $ALIEN_JDL_ANCHOR_SIM_OPTIONS == *"--tpc-distortion-type 2"* ]]; then | ||
| export O2DPG_ENABLE_TPC_DISTORTIONS=ON |
There was a problem hiding this comment.
@sawenzel suppression of this line leads to disabling corrections in the reconstruction even if distortions were used in the digitization (this happened in the recent test of Mesut LHC25b8a_default_v4, while in LHC25b8a_default_v3 they were OK).
I remember you did something else to detect distortion used in the digi. but I don't remember what and it seems it did not work. Shall we simply restore this line?
A bug for TPC distortion treatment crept in with the refactor of AliceO2Group#1966 This commit fixes it.
A bug for TPC distortion treatment crept in with the refactor of AliceO2Group#1966 This commit fixes it.
A bug for TPC distortion treatment crept in with the refactor of #1966 This commit fixes it.
This commit refactors the transfer of anchoring configuration from async-reco scripts into the MC pipeline, addressing O2-5011 by replacing the previous whitelisting mechanism with a blacklisting approach.
In addition, it introduces broader configuration/customization support: users can now inject arbitrary command-line options into any task via a
customize.jsonfile, reducing the need to edit workflow scripts.For example:
{
"ConfigParams": {
"EMCSimParam": {
"mBusyTime": "11.11"
}
},
"Executables": {
"o2-ft0-reco-workflow": {
"filtered": {
"--my-custom-option": "foo"
}
},
"ft0fv0emcctp_digi": {
"filtered": {
"--another-custom-option": "baz"
}
}
}
}
This allows for flexible injection of both configKeyValues and CLI options via
o2dpg_sim_workflow.py --overwrite-config customize.json.