MUON: add default values for number of MFT-MCH matching candidates#1925
Conversation
aferrero2707
requested review from
chiarazampolli,
davidrohr,
sawenzel and
shahor02
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
+async-label async-2024-PbPb-apass2, async-2023-PbPb-apass5 |
|
@mcoquet642 could you please have a look? Thanks a lot! |
|
Thanks Andrea, this looks fine for me |
|
Dear @sawenzel , @chiarazampolli, @shahor02 could you please see if this could be merged, so that it can be included in the software freeze ? Thanks |
|
@sawenzel, can you check and if all is fine merge this PR? We need this to produce the new tag for PbPb apass |
|
Dear @davidrohr , could you please check this PR? We need this to produce the new tag for PbPb |
|
sorry, didn't see this. Is this needed only for async? Then I would prefer to have it in setenv_extra.sh, not in the general setenv.sh. |
|
@davidrohr yes, it is only needed for async. I will move the initializations in setenv_extra.sh and update the PR. |
|
Hi @aferrero2707, did you move the initializations to setenv_extra.sh? |
The default number of matching candidates to be saved in output AO2Ds is set to 5 for pp and 20 for Pb-Pb. For other beam typoes it is set to zero, which prevents from adding the FwdMatching.saveMode and FwdMatching.nCandidates options to the forward matching workflow. Setting the MUON_MATCHING_NCANDIDATES environment variable ovverrides the default values. The variable initialization has been moved to the setenv_extra.sh file because it is only used for async processing.
Head branch was pushed to by a user without write access
aferrero2707
force-pushed
the
muon-matching-set-default-ncandidates
branch
from
c0542f5 to
e00df37
Compare
|
@alcaliva @davidrohr @mcoquet642 I moved the initializations in |
| [[ ! -z ${ITS_STROBE:-} ]] && ITSMFT_STROBES+="ITSAlpideParam.roFrameLengthInBC=$ITS_STROBE;" | ||
| [[ ! -z ${MFT_STROBE:-} ]] && ITSMFT_STROBES+="MFTAlpideParam.roFrameLengthInBC=$MFT_STROBE;" | ||
|
|
||
| MFTMCH_NCANDIDATES_OPT= |
There was a problem hiding this comment.
@aferrero2707 : Sorry, but this line must stay in setenv.sh, since this one is also used in online :(.
There was a problem hiding this comment.
@davidrohr why you say this is needed for online as well? AFAIK we are not using the option for multiple candidates in online.
In the previous PR I have put the lines in setenv.sh because I was not aware of the setenv_extra.sh specific for async processing...
There was a problem hiding this comment.
Ah, ok, I didn't know that.
I thought also MFTMCH_NCANDIDATES_OPT must be set for sync, since it is used.
But it is actually used like [[ ! -z ${MFTMCH_NCANDIDATES_OPT:-} ]] && , so ok if unset.
I'll revert my moving of the fail. Thx for checking and sorry for the confusion.
|
I'll move it back myself to get this going. |
5 participants
The default number of matching candidates to be saved in output AO2Ds is set to 5 for pp and 20 for Pb-Pb. For other beam types it is set to zero, which prevents from adding the
FwdMatching.saveModeandFwdMatching.nCandidatesoptions to the forward matching workflow.Setting the
MUON_MATCHING_NCANDIDATESenvironment variable overrides the default values.