[O2B-1558] Set filters from url upon page reload#2144
Open
NarrowsProjects wants to merge 21 commits into
Open
Conversation
NarrowsProjects
added
frontend
javascript
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
- Coverage 45.88% 45.80% -0.09%
==========================================
Files 1035 1035
Lines 17165 17195 +30
Branches 3123 3132 +9
==========================================
Hits 7877 7877
- Misses 9288 9318 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NarrowsProjects
changed the base branch from
main
to
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
NarrowsProjects
force-pushed
the
feature/O2B-1558/Set-filters-from-URL-upon-page-reload
branch
4 times, most recently
from
82c8d41 to
e157e08
Compare
NarrowsProjects
force-pushed
the
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
branch
5 times, most recently
from
beca3c1 to
319bb4d
Compare
NarrowsProjects
force-pushed
the
feature/O2B-1558/Set-filters-from-URL-upon-page-reload
branch
2 times, most recently
from
767f763 to
6add680
Compare
Base automatically changed from
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
to
main
May 26, 2026 14:19
added 8 commits
May 27, 2026 10:51
NarrowsProjects
force-pushed
the
feature/O2B-1558/Set-filters-from-URL-upon-page-reload
branch
from
6add680 to
d23795c
Compare
graduta
requested changes
May 27, 2026
Member
There was a problem hiding this comment.
Comment for general description of the PR, it does more than what you mention:
- changes the use of textInput component
- changes EOR
- adds the logger
Comments for the logger - as you are introducing lots of duplicated code, I belive this would be better to be added as a middleware method and separate ticket
Comment for the call to set from URL. Could this not be added in a common space, perhaps something like in the setter of pageIdentifier?
| */ | ||
| const listDataPassesHandler = async (req, res) => { | ||
| const { path, session: { id }, query } = req; | ||
| const filters = query?.filters; |
Member
There was a problem hiding this comment.
I believe it is filter without the s
Collaborator
Author
There was a problem hiding this comment.
You're right
| } | ||
| } | ||
|
|
||
| module.exports = new FilterLogger; |
graduta
requested changes
May 27, 2026
Member
There was a problem hiding this comment.
I believe I identified a bug that needs to be taken care of:
- open a summary page (let's say logs)
- set a filter (let's say "No Anonymous")
- pages succesfully gets updated and the URL as well
- use the browser "Go Back" navigation button
- URL gets updated but the request towards the backend will still contain the filter applied
When fixing the test, please add a test for this scenario as well
| * @param {boolean} resetUrl Whether to remove all the active filters from the urls | ||
| * @return {void} | ||
| */ | ||
| resetFiltering(fetch = true, clearUrl = false) { |
Member
There was a problem hiding this comment.
I think you updated the docs from the other file similar changes, but you did not apply the change to the implementaiton
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
added 2 commits
May 27, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: