Skip to content

New geometry - #15791

Open
pkurash wants to merge 37 commits into
AliceO2Group:devfrom
pkurash:new_geometry
Open

New geometry#15791
pkurash wants to merge 37 commits into
AliceO2Group:devfrom
pkurash:new_geometry

Conversation

@pkurash

@pkurash pkurash commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

New code for the Forward Detector. Modified eta coverage and module configuration, two extra Cherenkov modules.

@njacazio njacazio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pkurash ! Here a couple of minor suggestions

Comment thread Detectors/Upgrades/ALICE3/FD3/base/files/fd3_cherenkov_xy_v1.dat Outdated
Comment thread Detectors/Upgrades/ALICE3/FD3/base/files/fd3_cherenkov_xy_v2.dat Outdated
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 4706dc8 at 2026-09-13 07:44:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD3/simulation/src/Detector.cxx:408:12: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@njacazio
njacazio enabled auto-merge (squash) September 13, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants