TPC VDrift: make VDriftHelper usable outside DPL (e.g. O2Physics) - #15749
Merged
Merged
Conversation
Split VDriftHelper::extractCCDBInputs into the CCDB-fetching part and a framework-independent updateVDrift() and add BasicCCDBManager-based overloads to VDriftHelper/PressureTemperatureHelper so O2Physics can call these directly instead of reimplementing the T/P-scaling logic (see AliceO2Group/O2Physics#17656). Calling these every event is cheap: laser/TGL/pressure/temperature are only re-accounted when the underlying CCDB object actually changed and logging is throttled to avoid stdout spam in trains.
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
September 2, 2026 07:24
shahor02
approved these changes
Sep 2, 2026
shahor02
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @matthias-kleiner !
@f3sch with this you just need to create a VDriftHelper instance and simply do
mVDHelper.extractCCDBInputs(*mCCDB, timestamp);
return mVDHelper.getVDriftObject().getVDrift();
either directly from the analysis task of from your TPCVDriftManager.
mhemmer-cern
reviewed
Sep 2, 2026
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 489d19f at 2026-09-08 21:44: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split VDriftHelper::extractCCDBInputs into the CCDB-fetching part and a framework-independent updateVDrift() and add BasicCCDBManager-based overloads to VDriftHelper/PressureTemperatureHelper so O2Physics can call these directly instead of reimplementing the T/P-scaling logic (see AliceO2Group/O2Physics#17656). Calling these every event is cheap: laser/TGL/pressure/temperature are only re-accounted when the underlying CCDB object actually changed and logging is throttled to avoid stdout spam in trains.