Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jan 30, 2026

  • Out of line and avoid usage of stringstream.
  • Remove non-sense abbreviations

- Out of line and avoid usage of stringstream.
- Remove non-sense abbreviations
@ktf ktf requested a review from a team as a code owner January 30, 2026 11:19
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ktf
Copy link
Member Author

ktf commented Jan 30, 2026

Apart from some detectors and ALICE3 I most notably missed "MC" as an abbreviation. I suggest to add those in a separate PR. In any case, it should behave as before in the worst case scenario.

@mhemmer-cern
Copy link
Contributor

Hello @ktf
I am happy to see EMCal/EMC in there. If there would be a possibility to add more abbreviations, from the PWGEM Photon side we would like to add PCM (photon conversion method) and PHOS (for the converted data and the early Run3 data where PHOS was included).
Thanks a lot for looking into this!

@ktf
Copy link
Member Author

ktf commented Jan 30, 2026

@mhemmer-cern yes, of course. As I said, please let's see this PR green and merge it and then we can add everything which is missing.

@vkucera
Copy link
Collaborator

vkucera commented Jan 30, 2026

How many wagons will break because of the changed device names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants