GPU: Wshadow compiler directive not needed in HIP Includes System#14738
GPU: Wshadow compiler directive not needed in HIP Includes System#14738davidrohr merged 2 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| #include <hipcub/hipcub.hpp> | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wshadow" // FIXME: Is this still needed? | ||
| // #pragma GCC diagnostic ignored "-Wshadow" // VS: This compiler directive for -Wshadow is not needed. |
There was a problem hiding this comment.
If you remove the pragma diagnostic ignored, please also remove the related pragma diagnostic push and pop. And you can also please remove the lines, not just comment them. Finally, if you work in the GPU code, please prepend the PR title with a "GPU:"
There was a problem hiding this comment.
Thanks David,
I'll remove all three lines (push, pragma diagnostic, pop) and commit again.
Changed the PR name from TODO to GPU.
vikasssinghal
changed the title
…iceO2Group#14738) * TODO: Wshadow compiler directive not needed * Removed all three lines push, pragma diagnostic, pop
2 participants
GCC Compiler directive for Wshadow is not needed, therefore commented the line.