DPL Analysis: rework cursor logic keeping the gsl::span for VLAs#14607
DPL Analysis: rework cursor logic keeping the gsl::span for VLAs#14607ktf merged 4 commits intoAliceO2Group:devfrom
gsl::span for VLAs#14607Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Looks good. Shall I test it on hyperloop? |
|
Let's wait for the rest of CI to complete, the issues in the previous version were specifically with o2_slc9 |
|
@ktf this time it was all-green in CI. I've committed the suggested change and now it is ready for testing on Hyperloop. |
|
Tested on hyperloop (Correlations, histograms). No regressions spotted. |
|
I think in the ASoA.h we still have: gsl::span<const _Type_> inline getIds() const \
{ \
return _Getter_##Ids(); \
} \
\
gsl::span<const _Type_> _Getter_##Ids() const \
{ \
return *mColumnIterator; \
} Which results in table converters when trying to fill values of the old table into the new table in errors, because the new table is expecting |
Replace
gsl::spanwithstd::spanalmost everywhere.Make sure the cursor table fill can accept span.