DPL CCDB: avoid duplicated code

[ktf]

No description provided.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

[alibuild]

Error while checking build/O2/fullCI_slc9 for de9dbc8 at 2025-08-07 18:25:

++ cp /sw/slc9_x86-64/O2/14560-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14560-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/14560-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

[ktf]

@singiamtel any idea why it's now failing the clang-tidy part? IIRC you changed something related?

[ktf]

@shahor02 elsewhere we have a similar pattern, but using an else if rather than a separate else statement. Is that actually expected to be different here?

[singiamtel]

@singiamtel any idea why it's now failing the clang-tidy part? IIRC you changed something related?

The change I made was trying to fix that exact error, I guess it didn't work... It's O2-6169

[alibuild]

Error while checking build/O2/fullCI_slc9 for 9fa4c3d at 2025-08-16 02:42:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[44674:internal-dpl-ccdb-backend]: [02:41:38][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[44674:internal-dpl-ccdb-backend]: [02:41:38][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[44674:internal-dpl-ccdb-backend]: [02:41:38][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[44674:internal-dpl-ccdb-backend]: [02:41:38][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alissandra05-1755304892-HK9Gny) with http code: 0
[44674:internal-dpl-ccdb-backend]: [02:41:38][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[44674:internal-dpl-ccdb-backend]: [02:41:38][FATAL] Unable to find CCDB object CTP/Calib/OrbitReset/1550600800000
[44674:internal-dpl-ccdb-backend]: [02:41:38][ERROR] Exception while running: Fatal error. Rethrowing.
[44674:internal-dpl-ccdb-backend]: [02:41:38][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 44674 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d0b5f98c0654f0f5b420858ef39878308032b566/slc9_x86-64/o2checkcode/1.0-local60/etc/modulefiles
++ cat
--

Full log here.

[ktf]

Will do it differently...