Repository navigation
fix: acknowledge native server startup and verify fresh installs - #70
Merged
Merged
Conversation
anycodes
marked this pull request as ready for review
October 19, 2026 09:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #69. Native
start_server()now consumes the lazy process stream and requires a process acknowledgement before reporting startup, includingwait=False. A failed launch no longer appears healthy while no server listens. The standard sync/async public contract is unchanged.Type of Change
Changes
Testing
Full local client checkpoint:2186 passed/24 skipped/10 integration deselected; final changed helpers16 pass. Unchanged server full checkpoint:852 passed/3 failed/1 skipped. One failure was a pip-free audit venv and passes after pip installation; two raw protocol tests receive proxy502 locally. Their assertions are retained and full hosted Python3.10–3.12 matrices must pass before merge.
Checklist
Definition of Done
.agents/notes/implemented/feature/2026-10-19-server-start-acknowledgement.mdand.agents/evidence/verify/2026-10-19-server-start-acknowledgement.mdCloud/model acceptance ran locally only. No cloud/model Actions or credential upload. Native module command requires the runtime/commands file to be installed in the sandbox; this PR does not certify all experimental templates.
Public entry-point follow-up: corrected stale native SDK usage install steps (both languages), community source snippets, SECURITY distribution names and CLI owner labels. Historical comparison tables now clearly route readers to current guides; no live discussion message posted. Health106 PASS/1 WARN/0 FAIL and hygiene PASS after these edits.