Repository navigation
fix(providers): enforce native PTY before context or wire access - #68
Merged
Merged
Conversation
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #36. Extract the native terminal guard from conditional migration PR47 so current native main receives the fix independently.
An Express terminal lacking its declared PTY feature previously touched session/wire state and raised an incidental error. Check the provider declaration first and preserve the typed unsupported-feature contract. Valid native APIs and available backend behavior are unchanged.
Type of Change
Changes
Testing
Regression1 FAIL before/1 PASS after. Full client2180 PASS/24 SKIP; maintained lint/format/mypy both packages PASS. Actual local Express112 PASS/2 Volume opt-in SKIP/2 slow DESELECT/1 documented KI-009 XFAIL. Tracker cleanup plus independent read-only complete list confirmed zero current-date E2E-tagged sandboxes; no unrelated resource changed.
Server/distribution code is unchanged. Exact latest-head full hosted Python3.10/3.11/3.12 client/server/package matrix will be verified before normal merge. No cloud/model Actions acceptance or credentials added.
Documentation and records
English/Chinese provider guides, CHANGELOG, proposed owner note and verification under .agents use topic2026-10-18-provider-preflight. Parent standard migration/conditional pause/snapshot prerequisites remain in PR47.
Checklist
Definition of Done