Repository navigation
fix(providers): keep compatibility rules and metadata adapter owned - #67
Merged
Merged
Conversation
… into refactor/provider-isolation-20261018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merged isolation code still formatted native envd URLs in core compatibility helpers, bypassing an adapter-owned rule. Pure Express configuration data lives in the provider; a separate distribution composition supplies neutral configuration through compatibility exports. Historical URL helpers call the composed provider-owned builder. Neutral imports still load no native authentication/runtime adapter.
Fixes #66. Counterpart: Alibaba-Agent-Sandbox/agent-sandbox#61. Original isolation PR is already merged; this follow-up completes its metadata/rule ownership boundary.
Type of Change
Changes
Testing
Latest-head Python3.10/3.11/3.12 client/server matrices, package builds, hygiene and Markdown links all pass. Local full client2178 passed/24 skipped, then the9-pass isolation file covers the appended owned-builder regression. Both-package ruff/format/mypy and combined clean wheel imports pass. The disclosed local malformed HTTP intermediary failures remain separate; their unchanged assertions pass in hosted server jobs.
Real merged-source Express smoke:58 passed,1 known Jupyter xfail,1 throughput-dependent non-strict xpass. Current executable cloud/management cases pass with2 owned sandboxes deleted and zero leaked; corrected offline rerun61 passed/1 no-resource skip. Earlier116-pass full E2E and fresh OSS persistence2-pass/binary mount2-pass runs remain at their recorded implementation revisions. Temporary key/Volume/Bucket/policy/role deletion and independent zero-sandbox listing are verified.
Health/hygiene and configured-secret scans pass. Details:
.agents/evidence/verify/2026-10-18-provider-owned-metadata-followup.md, plus its linked convergence and real-storage records.Checklist
Definition of Done
Native E2B/Cube/container/OpenSandbox environment acceptance and the separately gated image-factory contract are outside this repair; no new native coverage or package release is claimed.
Post-merge verification: merged as
5a99f0fa294d1b801e1006981d2af87e3a486507; the exact main-branch CI matrix also passed all configured jobs. The linked owner Issue #66 is closed. No package publication is implied.