fix: 馃悰 preserve input precision in apply and compress - #36
Open
SimoneGasperini wants to merge 4 commits into
Open
SimoneGasperini wants to merge 4 commits into
SimoneGasperini wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13.
Description
applyandcompresspreviously had default tofloat64Gaussian random sketch, silently promotingfloat32andcomplex64inputs to double precision.I implemented a simple utility function
sketch_dtypeto infer the default sketch dtype from the input arrays, preserving single precision where appropriate. Explicitdtypeoverrides remain supported.I also added tests to cover all four primitives: MPS compression, MPO compression, MPO-MPS application, and MPO-MPO application. Each runs with
float32,float64,complex64, andcomplex128inputs, checking that the output retains the input dtype and reproduces the original tensor within the appropriate tolerance.