Skip to content

fix(ci): fix release-asset upload job - #364

Open
ludmilaasb wants to merge 1 commit into
mainfrom
fix/release-upload-gh-repo
Open

ludmilaasb wants to merge 1 commit into
mainfrom
fix/release-upload-gh-repo

Conversation

@ludmilaasb

@ludmilaasb ludmilaasb commented Sep 17, 2026

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Summary

The Attach wheels and sdist to GitHub release job in deploy.yml (upload_release_assets) failed on the v0.9.1 release with:

failed to run git: fatal: not a git repository (or any of the parent directories): .git

This job downloads the built wheels/sdist artifacts into dist/. gh release upload resolves the target repository by reading the local git remote without pointing out the repository itself, then there was no .git present therefore the error.. This has been broken since the job was introduced in #176; it appears this is the first release to actually exercise this code path.

Changes

  • Set GH_REPO: ${{ github.repository }} on the "Upload wheels and sdist to release" step so gh can resolve the target repo without needing a full checkout.

Checklist

  • Tests added or updated to cover the changes — N/A, CI workflow config only
  • Documentation updated (docstrings, docs/, CONTRIBUTING.md) if needed
  • CHANGELOG / release notes updated if applicable

AI/LLM disclosure

  • I did not use LLM tooling, or used it only privately for ideation
  • I used the following tool to help write this PR description: Claude Code
  • I used the following tool to generate or modify code: Claude Code

Note

The v0.9.1 release assets still need to be attached manually (or by re-running the failed job once this fix is merged and manually re-triggering upload_release_assets for that release), since the release itself already published without them.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved release asset uploads in the PyPI deployment workflow by explicitly identifying the target repository.

`upload_release_assets` never checks out the repository, so `gh
release upload` had no git remote to resolve the target repo from and
failed with "fatal: not a git repository" on the v0.9.1 release.
Setting GH_REPO explicitly lets gh resolve the repo without needing a
checkout.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b3959b11-34d2-4b80-a988-26791f6cb5f1

📥 Commits

Reviewing files that changed from the base of the PR and between 25b7465 and 14eec24.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PyPI deploy workflow now sets GH_REPO from github.repository for the gh release upload step.

Changes

Release upload targeting

Layer / File(s) Summary
Configure release upload repository
.github/workflows/deploy.yml
The gh release upload step now sets GH_REPO to ${{ github.repository }}.

Priority: ⚪ Not assessed

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 14eec

The release workflow now explicitly targets the current repository for uploading release assets and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: setting GH_REPO for the release-asset upload job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-upload-gh-repo

Comment @coderabbitai help to get the list of available commands.

@ludmilaasb ludmilaasb closed this Sep 17, 2026
@ludmilaasb
ludmilaasb deleted the fix/release-upload-gh-repo branch September 17, 2026 10:24
@github-actions

Copy link
Copy Markdown

Docs preview: https://pr-364.monoprop-docs.pages.dev

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (25b7465) to head (14eec24).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          14       14           
  Lines         752      752           
  Branches      101      101           
=======================================
  Hits          735      735           
  Misses         12       12           
  Partials        5        5           
Flag Coverage Δ
cpp 97.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ludmilaasb ludmilaasb changed the title fix(ci): 🐛 set GH_REPO for release-asset upload job fix(ci): fix release-asset upload job Sep 17, 2026
@ludmilaasb
ludmilaasb restored the fix/release-upload-gh-repo branch September 17, 2026 10:43
@ludmilaasb ludmilaasb reopened this Sep 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant