fix(ci): fix release-asset upload job - #364
ludmilaasb wants to merge 1 commit into
Conversation
`upload_release_assets` never checks out the repository, so `gh release upload` had no git remote to resolve the target repo from and failed with "fatal: not a git repository" on the v0.9.1 release. Setting GH_REPO explicitly lets gh resolve the repo without needing a checkout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PyPI deploy workflow now sets ChangesRelease upload targeting
Priority: ⚪ Not assessed Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The release workflow now explicitly targets the current repository for uploading release assets and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Docs preview: https://pr-364.monoprop-docs.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 14 14
Lines 752 752
Branches 101 101
=======================================
Hits 735 735
Misses 12 12
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|



🤖 AI text below 🤖
Summary
The
Attach wheels and sdist to GitHub releasejob indeploy.yml(upload_release_assets) failed on the v0.9.1 release with:This job downloads the built wheels/sdist artifacts into
dist/.gh release uploadresolves the target repository by reading the local git remote without pointing out the repository itself, then there was no.gitpresent therefore the error.. This has been broken since the job was introduced in #176; it appears this is the first release to actually exercise this code path.Changes
GH_REPO: ${{ github.repository }}on the "Upload wheels and sdist to release" step soghcan resolve the target repo without needing a full checkout.Checklist
docs/,CONTRIBUTING.md) if neededCHANGELOG/ release notes updated if applicableAI/LLM disclosure
Note
The v0.9.1 release assets still need to be attached manually (or by re-running the failed job once this fix is merged and manually re-triggering
upload_release_assetsfor that release), since the release itself already published without them.🤖 Generated with Claude Code
Summary by CodeRabbit