Skip to content

chore!: bump maximum number of modes to 1024 - #332

Merged
robertodr merged 2 commits into
mainfrom
rdre-bump-max-modes
Sep 3, 2026
Merged

robertodr merged 2 commits into
mainfrom
rdre-bump-max-modes

Conversation

@robertodr

@robertodr robertodr commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

Bump the maximum number of modes to 1024

Checklist

  • Tests added or updated to cover the changes
  • Documentation updated (docstrings, docs/, CONTRIBUTING.md) if needed
  • CHANGELOG / release notes updated if applicable

AI/LLM disclosure

  • I did not use LLM tooling, or used it only privately for ideation
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

Important

By opening this PR I confirm that I have read CONTRIBUTING.md and I agree to the terms of the Contributor License Agreement.

Warning

If you're contributing on behalf of your employer, contact cla@algorithmiq.fi to arrange a Corporate CLA.

@github-actions github-actions Bot added documentation Improvements or additions to documentation cpp labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Docs preview: https://pr-332.monoprop-docs.pages.dev

@robertodr
robertodr force-pushed the rdre-bump-max-modes branch 2 times, most recently from 72372a3 to 7559d78 Compare September 2, 2026 09:28
@robertodr robertodr changed the title chore!: bump maximum number of modes to 1000 chore!: bump maximum number of modes to 1024 Sep 2, 2026
@robertodr
robertodr enabled auto-merge (squash) September 2, 2026 09:32
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@996e938). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage        ?   97.70%           
=======================================
  Files           ?       14           
  Lines           ?      742           
  Branches        ?       98           
=======================================
  Hits            ?      725           
  Misses          ?       12           
  Partials        ?        5           
Flag Coverage Δ
cpp 97.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@robertodr

Copy link
Copy Markdown
Member Author

It seems it doesn't blow up the build times, which is good news!

It's bad news for PR #308, but that's OK

@robertodr
robertodr force-pushed the rdre-bump-max-modes branch 2 times, most recently from ad93ffb to 6fcd3a0 Compare September 2, 2026 13:38
@robertodr
robertodr merged commit 9129f92 into main Sep 3, 2026
28 checks passed
@robertodr
robertodr deleted the rdre-bump-max-modes branch September 3, 2026 10:08
@sonarqubecloud

sonarqubecloud Bot commented Sep 3, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants