Harden replay path resolution#150
Merged
AlexanderOnischenko merged 2 commits intofeature/tracerfrom Feb 8, 2026
Merged
Conversation
Owner
Author
|
@codex, please review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
base_dir is Noneallowed resolving arbitrary local paths.Description
base_dirinReplayContext.resolve_resource_pathand raiseValueErrorwhen it is not provided, and when an absoluteresource_pathis supplied.safe_join_under_validated(root, rel_path: Path)and keepsafe_join_under(root, rel_posix: str)to avoid duplicate validation while still ensuring a joined path does not escaperoot.ReplayContext.resolve_resource_pathto validate the POSIX-relative resource withvalidate_run_relative_posixand to usesafe_join_under_validatedfor all resolved locations (directresources/paths and fixture lookups).copy_resource_filesinsrc/fetchgraph/replay/export.pyto validate and usesafe_join_under_validatedfor both source (run_dir) and destination (out_dir) lookups to avoid writing outside expected roots.__all__infetchgraph.utils.path_layoutand clean up double-validation patterns.tests/test_replay_runtime.pycoveringbase_dirrequirement, absolute path rejection, parent-traversal rejection, allowed inside-base resolution, and symlink escape rejection.Testing
pytest tests/test_replay_runtime.pyand all tests passed:7 passed(no failures).Codex Task