fix(IngredientPictureSerializer): Use picture_url - #214
Merged
Merged
Conversation
This returns the image url with all settings applied, including cropping and format options. The current value returns the original image in any case, which is not what we would expect.
tvdeyen
force-pushed
the
fix-ingredient-picture-value
branch
from
September 28, 2026 16:22
26840ea to
828060d
Compare
We have mandatory checks in github and they do not support paths, we we need to run all checks regardless of the paths.
sascha-karnatz
approved these changes
Sep 29, 2026
mamhoff
approved these changes
Sep 29, 2026
tvdeyen
added
bug
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
tvdeyen
added a commit
that referenced
this pull request
Sep 29, 2026
…#217) # Backport This will backport the following commits from `main` to `8.2-stable`: - [fix(IngredientPictureSerializer): Use picture_url (#214)](#214) <!--- Backport version: 12.0.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)
Merged
tvdeyen
added a commit
that referenced
this pull request
Sep 29, 2026
## Release v8.2.1 <!-- Release notes generated using configuration in .github/release.yml at 8.2-stable --> ## What's Changed ### Bug Fixes * [8.2-stable] fix(IngredientPictureSerializer): Use picture_url (#214) by @alchemycms-ci-bot in #217 ### Performance Improvements * [8.2-stable] Route element visibility through ElementsRepository (#196) by @alchemycms-ci-bot in #215 * [8.2-stable] refactor: load elements through core's shared element repository (#199) by @alchemycms-ci-bot in #216 ## New Contributors * @alchemycms-ci-bot made their first contribution in #215 **Full Changelog**: v8.2.0...v8.2.1 --- This PR was automatically created by the prepare-release workflow. Once merged, the gem will be automatically published to RubyGems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This returns the image url with all settings applied, including cropping and format options. The current value returns the original image in any case, which is not what we would expect.