fix(frontend): center AuthSideBanner content to fix gap on wide screens - #6226
Conversation
|
@oforiwaasam is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe auth side banner now horizontally centers its inner content container within the panel. ChangesAuth banner layout
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized layout change centers the authentication banner content on wide screens without changing behavior, data, permissions, or runtime configuration; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @oforiwaasam thank you for the PR. I don't think this is the right approach to fix this issue; we need to think about how we can reduce the white space that much. And that requires design alignment and some suggestions as well: how can we improve the view for large screens |
|
Thanks for the feedback, @ashrafchowdury. I agree that if we want to prioritize reducing how much of the white space there is, then this approach isn't the best. For suggestions on my end to improve the view for large screens, we can cap the entire page's width or just the panel's width so the panel's content stays balanced within the panel as the viewport grows. Let me know what you think about these two suggestions or if you have a specific design direction in mind already, we can discuss that further too. |
|
qa passed for 43d9a1b. here is the recording: https://www.browserbase.com/sessions/1310b4b3-9b99-4037-b4b5-faa20f88c99e
|
Summary
On a wide display the sign-in page splits into a fixed-width form on the left and a marketing panel on the right. The panel's content — the GitHub chip, the "Build agents that automate your work" headline, and the three feature rows — sits against the panel's left edge and stops well short of its right edge. Everything past that point stays blank, and the gap grows with the viewport. In the attached screenshot (~1780px wide) roughly half the panel is empty, which makes the page look unfinished.
Root cause: flexbox's default cross-axis alignment (
align-items: stretch) doesn't center a width-capped child, it just anchors it to the start of the cross axis. The fix addsmx-autoto the content wrapper so it stays horizontally centered within the panel as the panel grows.This component lives in the shared
agenta-auth-uipackage (AuthSideBanner.tsx), consumed byAuthShellacross OSS, EE, and mobile, so the fix applies everywhere the banner is rendered.Testing
Verified locally
./hosting/docker-compose/run.sh --oss --dev --web-local/authlocally on my personal wide screen and at 1780×900 and 1900px+ widths (via Chrome DevTools responsive mode) before and after changes; panel content now stays centered instead of hugging the left edge (see before and after screenshots attached in Demo section)pnpm format-fixandpnpm lint-fixinwebAdded or updated tests
N/A; this is a single-class CSS/layout fix with no behavioral change, so no new test coverage was added.
Demo
BEFORE changes
AFTER changes
Checklist
Contributor Resources
Issue
Closes #6148