[FE fix] Providers and models table improvements#4497
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates provider credential handling and display semantics. Sensitive credential fields are marked as password-type in field definitions and rendered with password masking in the form component. The provider settings table is restructured to show provider names and their associated models as separate columns. UI labels are updated to clarify the provider/model distinction, and test fixtures are aligned with the new terminology. ChangesProvider Credential Security and Display Enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/oss/src/pages/w/[workspace_id]/p/[project_id]/settings/index.tsx (1)
116-116:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate breadcrumb label to match page title.
The breadcrumb for the "secrets" tab still returns
"Models", but the page title (line 164) has been updated to"Providers & Models". This creates an inconsistent user experience.🔧 Proposed fix
case "secrets": - return "Models" + return "Providers & Models"
🧹 Nitpick comments (1)
web/oss/src/components/ModelRegistry/assets/LabelInput/index.tsx (1)
42-43: ⚡ Quick winConsider using specific autoComplete values for password fields.
Modern browsers often ignore
autoComplete="off"for password fields. For better browser compatibility and UX, useautoComplete="new-password"for credential configuration forms (which this appears to be) orautoComplete="current-password"for login forms.🔐 Proposed improvement
<Input.Password variant="borderless" className={clsx("px-0 rounded-none", className)} spellCheck={false} - autoComplete="off" + autoComplete="new-password" {...props} />
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7cb2da30-1ab8-4f16-9a14-0d1775ac365d
📒 Files selected for processing (6)
web/oss/src/components/ModelRegistry/Drawers/ConfigureProviderDrawer/assets/constants.tsweb/oss/src/components/ModelRegistry/assets/LabelInput/index.tsxweb/oss/src/components/Sidebar/SettingsSidebar.tsxweb/oss/src/components/pages/settings/Secrets/SecretProviderTable/index.tsxweb/oss/src/pages/w/[workspace_id]/p/[project_id]/settings/index.tsxweb/tests/tests/fixtures/base.fixture/providerHelpers/index.ts
Summary
Testing
QA follow-up
go to settings and check
Providers & ModelsChecklist
Contributor Resources