Skip to content

[FE fix] Providers and models table improvements#4497

Open
ardaerzin wants to merge 5 commits into
mainfrom
fe-fix/providers-and-models-table-improvements
Open

[FE fix] Providers and models table improvements#4497
ardaerzin wants to merge 5 commits into
mainfrom
fe-fix/providers-and-models-table-improvements

Conversation

@ardaerzin
Copy link
Copy Markdown
Contributor

Summary

  • improved columns & column names
  • improved api key inputs
  • updated settings side menu link label

Testing

QA follow-up

go to settings and check Providers & Models

Checklist

  • I have included a video or screen recording for UI changes, or marked Demo as N/A
  • Relevant tests pass locally
  • Relevant linting and formatting pass locally
  • I have signed the CLA, or I will sign it when the bot prompts me

Contributor Resources

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 29, 2026 6:15pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Sensitive credential fields (API keys, access keys, session tokens) now properly display as masked password inputs for enhanced security.
  • UI Improvements

    • Renamed "Models" to "Providers & Models" in settings for clarity.
    • Updated provider table to display Provider and Models as separate columns.

Walkthrough

The PR updates provider credential handling and display semantics. Sensitive credential fields are marked as password-type in field definitions and rendered with password masking in the form component. The provider settings table is restructured to show provider names and their associated models as separate columns. UI labels are updated to clarify the provider/model distinction, and test fixtures are aligned with the new terminology.

Changes

Provider Credential Security and Display Enhancement

Layer / File(s) Summary
Password field configuration and rendering
web/oss/src/components/ModelRegistry/Drawers/ConfigureProviderDrawer/assets/constants.ts, web/oss/src/components/ModelRegistry/assets/LabelInput/index.tsx
Credential fields (apiKey, accessKeyId, accessKey, sessionToken) are marked with password-type attributes in the provider field definitions. The LabelInput component now detects password-type fields and renders them using Input.Password instead of standard Input, while consistently applying spellCheck={false} and autoComplete="off" to both password and non-password fields.
Provider table and label terminology
web/oss/src/components/pages/settings/Secrets/SecretProviderTable/index.tsx, web/oss/src/components/Sidebar/SettingsSidebar.tsx, web/oss/src/pages/w/[workspace_id]/p/[project_id]/settings/index.tsx
The provider table column configuration changes from displaying a "Model" field to a "Provider" field, and adds a new "Models" column that renders associated models as a list of tags. The sidebar menu entry and settings page title for the secrets tab are updated from "Models" to "Providers & Models" to reflect the new semantics.
Test fixture updates
web/tests/tests/fixtures/base.fixture/providerHelpers/index.ts
Page-readiness helpers for the settings/models page are updated to wait for and assert the presence of the "Providers & Models" heading instead of the previous "Models" heading.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Agenta-AI/agenta#4488: Both PRs modify the provider table in SecretProviderTable/index.tsx to restructure column definitions (this PR changes the Model/Provider distinction and adds Models column; related PR renames Status to API Key).
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 60.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: UI improvements to the providers and models table, API key input handling, and related UI updates.
Description check ✅ Passed The description is directly related to the changeset, listing the three main improvements made and providing QA testing instructions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fe-fix/providers-and-models-table-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ardaerzin ardaerzin marked this pull request as ready for review May 29, 2026 18:14
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. Frontend Improvement labels May 29, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
web/oss/src/pages/w/[workspace_id]/p/[project_id]/settings/index.tsx (1)

116-116: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update breadcrumb label to match page title.

The breadcrumb for the "secrets" tab still returns "Models", but the page title (line 164) has been updated to "Providers & Models". This creates an inconsistent user experience.

🔧 Proposed fix
                         case "secrets":
-                            return "Models"
+                            return "Providers & Models"
🧹 Nitpick comments (1)
web/oss/src/components/ModelRegistry/assets/LabelInput/index.tsx (1)

42-43: ⚡ Quick win

Consider using specific autoComplete values for password fields.

Modern browsers often ignore autoComplete="off" for password fields. For better browser compatibility and UX, use autoComplete="new-password" for credential configuration forms (which this appears to be) or autoComplete="current-password" for login forms.

🔐 Proposed improvement
 <Input.Password
     variant="borderless"
     className={clsx("px-0 rounded-none", className)}
     spellCheck={false}
-    autoComplete="off"
+    autoComplete="new-password"
     {...props}
 />

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7cb2da30-1ab8-4f16-9a14-0d1775ac365d

📥 Commits

Reviewing files that changed from the base of the PR and between a2df5cb and a01d74d.

📒 Files selected for processing (6)
  • web/oss/src/components/ModelRegistry/Drawers/ConfigureProviderDrawer/assets/constants.ts
  • web/oss/src/components/ModelRegistry/assets/LabelInput/index.tsx
  • web/oss/src/components/Sidebar/SettingsSidebar.tsx
  • web/oss/src/components/pages/settings/Secrets/SecretProviderTable/index.tsx
  • web/oss/src/pages/w/[workspace_id]/p/[project_id]/settings/index.tsx
  • web/tests/tests/fixtures/base.fixture/providerHelpers/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Improvement size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant