fix(mount): scale flush timeout per exact root - #37
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedNext included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review Please focus on whether the outer runtime timeout now matches the number of sequential exact-root flush commands, including pathless and explicit-timeout semantics. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Exact-head contract refinement at |
|
Exact-head local gate on |
Summary
SandboxOrchestrator.flushMountruntime timeout by the effective exact-layout root countFlushMountOptions.timeoutMsas a caller-owned whole-operation deadline0.1.9Why
#36 made the generated multi-root flush shell attempt every root and preserve the first failure. The orchestrator still wrapped that sequential shell in one fixed default 120-second runtime timeout. An early root could consume that budget and cause the runtime to terminate the shell before later roots ran, defeating the all-roots teardown contract one layer above the corrected shell.
Cloud has the same vendored method, and
packages/web/lib/fleet/sandbox-bridge.tsalso consumes this package. See AgentWorkforce/cloud#3143 and AgentWorkforce/cloud#3145.Regression proof
Before the production change, the new three-root default test failed with
120000 !== 360000, while the pathless control passed at120000. After the fix:git diff --check: passRelease
package.jsonand both package-lock version fields are0.1.9, matching the explicit release workflow contract. Do not publish until this PR is merged and release review is complete.