home: a search's pointer previews the match under it, and leaving gives the card back to the cursor - #1541
Merged
Conversation
Since #1071 the card beside a search read only the keyboard cursor, and a hover moved that cursor, so a redraw could hand it back to the start-a-new row whose card is empty: pointing at a match drew no card at all, and leaving the list could not restore the cursor's match. While a search is typed the pointer now previews the match under it and leaves the cursor where the keys put it; the card's own chords act on the card on screen, and any other key retires the hover. Resting home keeps #1071's one selection. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…he cursor Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the real-model tmux suite after the senior-dev wave.
TestTUIE2E/hover_previews_the_match_under_the_pointerfails on dev, and it is the only failure there that is the product rather than the suite (see #1540).What a person saw. At 180 columns, typing
Seedon Home lists the three matches. Pointing atSeed Betadrew nothing to the right of the list. The manual promises "a card … about the match under the cursor — or the one under your pointer while it is on one".Why. Since #1071 (
17ae56d34), the card has read only the keyboard cursor, and a hover moved that cursor. A redraw could hand the cursor back to thestart a new conversationrow, whose card is deliberately empty. Leaving the list could never restore the cursor's match, because the hover had overwritten it.Now. While a search is typed:
→,ctrl+o,ctrl+y, …) act on the card on screen.enterand typing still act on the cursor.Resting Home keeps #1071's single selection. A
folder gonematch still gets a card, and the manual now says so.Proof.
TestHomeSearchCardFollowsKeyboardCursor,…FollowsPointerMatch,…ReturnsToCursorWhenPointerLeavesandTestHomeSearchHasNoSideCardBelow136Columnsare written from the manual section, and each fails on the old code.make pr-readyis green, includinginternal/tui3's full sharded suite.🤖 Generated with Claude Code