-
Notifications
You must be signed in to change notification settings - Fork 14
fix(prose): keep bare numbered replies visible #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scui73414-bot
wants to merge
2
commits into
Agent-Field:dev
Choose a base branch
from
scui73414-bot:codex/fix-bare-numbered-reply
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| kind: fixed | ||
| title: Number-only assistant replies remain visible | ||
| pr: 1330 | ||
| # Optional. Which part of the repository this touches, so a reader can skip it. | ||
| # One or more of: build, chat, docs, engine, remote, resident | ||
| surface: [chat] | ||
| # Optional, and the reason this file exists. Every statement that WAS true and is | ||
| # not any more, written whole: what it was, and what it is now. A model reading | ||
| # this has to be able to check its own memory against it, so "branch names" is | ||
| # useless and "the trunk was chat-v3-task and no longer exists; work goes to dev" | ||
| # is the whole point. Leave the list empty if nothing anybody believed changed. | ||
| invalidates: [] | ||
| --- | ||
|
|
||
| The Markdown renderer now keeps an empty ordered-list marker in the transcript, | ||
| so replies such as `32.` are not silently dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reply-shaped case isn't the only thing that was being dropped — any body-less item took its own marker down with it, anywhere in a list. On
dev,"1. one\n2.\n3. three"renders asand with this change it renders all three rows. That's the case a future refactor of the
pop/pendingcontract is most likely to re-break, and it's silent when it does, so it's worth an assertion here alongside the two bare numbers.