Repository navigation
fix: 신규 카카오 가입의 활동 갱신 잠금 타임아웃을 제거한다 - #310
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
touch()를 부르지 않고 토큰만 발급한다. 생성자가 이미lastActiveAt을 넣는다 ([fix] #293 후속: 신규 카카오 가입이 활동 갱신의 별도 트랜잭션 잠금 대기로 HTTP 500 실패 #296).issueTokens()→touch()를 유지해 [fix] 카카오 소셜 로그인이 활동으로 집계되지 않는다: 재로그인해도 lastActiveAt 이 그대로라 INACTIVITY 사후 전달이 잘못 발동한다 #293 동작을 지킨다.Test plan
AuthServiceTest— 신규는touch없음, 기존은touch호출SocialLoginSignupLockMySqlTest— 신규 가입 lock wait 증가 없음, 기존 재로그인last_active_at갱신POST /api/v1/auth/social/login→ 200,isNewUser: trueFixes #296
Made with Cursor