Skip to content

Fix unknown properties returning None instead of raising AttributeError #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gourabsingha1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unknown properties returning None instead of raising AttributeError #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c850e
Fix unknown properties returning None instead of raising AttributeError
gourabsingha1 Jun 27, 2026
00a0335
Resolve parent attributes outside assertRaises to prevent false posit…
gourabsingha1 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Adyen/services/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ def __getattr__(self, attr):
client_attr = ["username", "password", "platform"]
if attr in client_attr:
return self.client[attr]
raise AttributeError(
f"'{self.__class__.__name__}' object has no attribute '{attr}'"
)


class AdyenServiceBase(AdyenBase):
Expand Down
8 changes: 8 additions & 0 deletions test/ClientTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,11 @@ class TestClient(unittest.TestCase):
client.xapikey = "YOUR_API_KEY"
client.platform = "test"
lib_version = settings.LIB_VERSION

def test_unknown_properties_raise_attribute_error(self):
with self.assertRaises(AttributeError):
_ = self.adyen.foobar
# Resolve parent attributes outside of assertRaises to avoid false positives
payments_api = self.adyen.payment.payments_api
with self.assertRaises(AttributeError):
_ = payments_api.foobar