Skip to content

Unit test for TransferWebhook (PR 2069) - #2080

Merged
ashwaniarya-adyen merged 2 commits into
mainfrom
test-case-transferwebook
Oct 9, 2026
Merged

ashwaniarya-adyen merged 2 commits into
mainfrom
test-case-transferwebook

Conversation

@ashwaniarya-adyen

@ashwaniarya-adyen ashwaniarya-adyen commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Adds test coverage for the transfer webhook models, branched off sdk-automation/transferwebhooks (PR #2069 )

 •  New mock transfer-updated-with-reversal.json for an issued card reversal webhook
 •  testTransferNotificationRequestWithReversalAndIssuedCardData: verifies full deserialization of the webhook (status, network reason, card category data, reversal event)
 •  testTransferWebhooksEnumDeserialization: verifies enum wire-value mapping and that unknown values deserialize to null instead of throwing

@ashwaniarya-adyen
ashwaniarya-adyen requested a review from a team as a code owner October 7, 2026 14:52
@ashwaniarya-adyen ashwaniarya-adyen self-assigned this Oct 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces unit tests to verify the deserialization of transfer webhooks, specifically focusing on transfer updates carrying an issued card reversal, as well as the wire-value mapping and forward compatibility of transfer webhook enums. A new mock JSON file representing a transfer update with a reversal has also been added. There are no review comments, so I have no feedback to provide.

@ashwaniarya-adyen ashwaniarya-adyen changed the title Unit test for PR 2069 Unit test for TransferWebhook (PR 2069) Oct 7, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@ashwaniarya-adyen
ashwaniarya-adyen added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit b158fd5 Oct 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants