Update unit references to use NXdata for datasets, include optional a…#307
Merged
briantoby merged 1 commit intoAdvancedPhotonSource:mainfrom Feb 16, 2026
Merged
Update unit references to use NXdata for datasets, include optional a…#307briantoby merged 1 commit intoAdvancedPhotonSource:mainfrom
briantoby merged 1 commit intoAdvancedPhotonSource:mainfrom
Conversation
Collaborator
|
@fgjorup is something missing from your comment? |
Contributor
Author
|
No no, GitHub just split the title of the pull request to continue in the description. I didn't realize it would look so odd. |
Collaborator
|
@fgjorup Thanks much for making this much more NeXus compatible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ttribute reading.
Modified to avoid reading mandatory fields from NXparameters, as the content and naming in NXparameters heavily depend on the implode diffraction integrater (e.g. azint, PyFAI, ...)