Fix empty object schemas to allow additional properties#464
Open
benedikt-buchert wants to merge 1 commit into
Open
Fix empty object schemas to allow additional properties#464benedikt-buchert wants to merge 1 commit into
benedikt-buchert wants to merge 1 commit into
Conversation
TargetRule, JsonNode, SegmentRule, and BatchAuthData are all defined as bare type: object with no properties. The API accepts and returns arbitrary fields on these types (e.g. TargetRule.script, JsonNode content values). Without additionalProperties: true, strictly-typed clients silently drop all fields on these objects. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four schemas are defined as bare `type: object` with no `properties` and no `additionalProperties`: TargetRule, JsonNode, SegmentRule, and BatchAuthData.
The Adobe Target API accepts and returns arbitrary fields on these types — for example `TargetRule.script` (audience rule script), and `JsonNode` content values. Without `additionalProperties: true`, strictly-typed clients (e.g. Pydantic, TypeScript strict mode) silently drop all fields on these objects, causing 400 errors when creating audiences with script-based rules.
Affected schemas and known fields:
Fix: Add `"additionalProperties": true` to each of these schemas so typed clients pass all fields through.
🤖 Generated with Claude Code