update to only allow prod in the deployment#58
Closed
louisachu wants to merge 1 commit into
Closed
Conversation
melissag-ensemble
requested changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
I think this misses the ticket. DEVSITE-1674 wants prod to stay main-only and not be deployable from non-main branches. (Slack)
Hardcoding env: prod changes behavior in the wrong direction:
| Branch | Before (dropdown) | After this PR |
|---|---|---|
main |
can deploy prod or stage & prod |
prod only — can no longer do stage & prod together |
| non-main | could select prod (the bug) |
still forces prod — bug not fixed, and no dropdown to avoid it |
AdobeDocs/adp-devsite-workflow#44 adds a guard in the central deploy-v2.yml that rejects prod deploys from non-main branches, which fixes this for every content repo without removing the dropdown options. I think we can close this one in favor of that. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the prod production to only deploy to prod only.
Related Issue
https://jira.corp.adobe.com/browse/DEVSITE-1674
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: